Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to .NET 8 #68

Merged
merged 17 commits into from
Dec 2, 2024
Merged

Upgraded to .NET 8 #68

merged 17 commits into from
Dec 2, 2024

Conversation

gigi81
Copy link
Contributor

@gigi81 gigi81 commented Dec 1, 2024

Upgraded the whole solution to .NET 8
Updated actions to use .NET 8 sdk
Updated to use central package management
Updated readme for SDK 8
Updated dependencies to more recent versions (excluding Avalonia)

@IngvarX
Copy link
Owner

IngvarX commented Dec 1, 2024

hey @gigi81 and thanks for opening this PR! I'll test it later today. Looks like PR build is failing while branch build is green but I guess it will be resolved after merge (do I need to do any setup for test reports though?). Is there anything else you're planning on including in this PR?

@gigi81
Copy link
Contributor Author

gigi81 commented Dec 1, 2024

Hey. Not sure what went wrong as I tried to build on my fork and it was fine. Let me try fix the build before merging. Will have a look tomorrow evening

@IngvarX
Copy link
Owner

IngvarX commented Dec 2, 2024

I pulled the latest version and it had dotnet target framework missing. I fixed that and tested the app locally. After that the build failed on UI tests because xunit execution setting is different now. I fixed that too. Apparently after the upgrade UI tests were disabled, had to enable them back and fix the issue with one of them. Builds are green now. Thanks for the contribution once again, I'm merging this PR

@IngvarX IngvarX merged commit f3d5aa3 into IngvarX:master Dec 2, 2024
3 checks passed
@gigi81 gigi81 deleted the feature/dotnet-8 branch December 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants