feat(controller): support serverless serving with 0-1 activator. #498
+616
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: X1aoZEOuO <[email protected]>
Signed-off-by: X1aoZEOuO <[email protected]>
Signed-off-by: X1aoZEOuO <[email protected]>
Signed-off-by: X1aoZEOuO <[email protected]>
Signed-off-by: X1aoZEOuO <[email protected]>
Signed-off-by: X1aoZEOuO <[email protected]>
InftyAI-Agent
added
needs-triage
X1aoZEOuO
force-pushed
the
feat/0-1-activator
branch
2 times, most recently
from
5424dec to
a7ae00f
Compare
|
/kind feature |
InftyAI-Agent
added
feature
X1aoZEOuO
force-pushed
the
feat/0-1-activator
branch
2 times, most recently
from
5d23e51 to
0a1d0fe
Compare
|
/cc @kerthcet |
pacoxu
reviewed
Oct 28, 2025
| flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.") | ||
| flag.StringVar(&namespace, "namespace", "llmaz-system", "The namespace of the llmaz to deploy") | ||
| flag.BoolVar(&enableServerless, "enable-serverless", false, "Enable the serverless feature") | ||
| flag.StringVar(&podIP, "pod-ip", "", "The pod IP of the llmaz controller manager") |
There was a problem hiding this comment.
Is this something like --bind-address ? Generally, we use 0.0.0.0 by default and check the exact pod IP at runtime.
There was a problem hiding this comment.
If podIP is only used for serverless mode, we should add a comment.
pacoxu
reviewed
Oct 28, 2025
| // ModelActivatorAnnotationKey is used to indicate whether the model is activated by the activator. | ||
| ModelActivatorAnnoKey = "activator.llmaz.io/playground" | ||
| // CachedModelActivatorAnnotationKey is used to cache the activator info of the model. | ||
| CachedModelActivatorAnnoKey = "cached.activator.llmaz.io" |
There was a problem hiding this comment.
the annotation naming style is not following the annotation and labels above.
pacoxu
reviewed
Oct 28, 2025
|
|
||
| // ModelActivatorAnnotationKey is used to indicate whether the model is activated by the activator. | ||
| ModelActivatorAnnoKey = "activator.llmaz.io/playground" | ||
| // CachedModelActivatorAnnotationKey is used to cache the activator info of the model. |
There was a problem hiding this comment.
Here is CachedModelActivatorAnnotationKey, below is CachedModelActivatorAnnoKey.
pacoxu
reviewed
Oct 28, 2025
| // Once either of them qualified, we'll expose this as a field in Model. | ||
| ModelPreheatAnnoKey = "llmaz.io/model-preheat" | ||
|
|
||
| // ModelActivatorAnnotationKey is used to indicate whether the model is activated by the activator. |
There was a problem hiding this comment.
comment name is not same as ModelActivatorAnnoKey
pacoxu
reviewed
Oct 28, 2025
| @@ -0,0 +1,564 @@ | |||
| /* | |||
| Copyright 2024 The InftyAI Team. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
In this update, several key improvements were made to support serverless operations and model activation. New constants were introduced to manage model activation states and cache information effectively.
Environment variables like
POD_IPwere added to dynamically configure networking settings, enhancing deployment flexibility. The main function was updated to include flags for enabling serverless features and configuring pod IPs, ensuring controllers can handle these operations smoothly.RBAC rules were expanded to allow more comprehensive resource management, including patching and updating endpoints. A new controller,
ActivatorReconciler, was implemented to manage model activation, service reconciliation, and traffic forwarding, crucial for serverless activations.Lastly, service creation logic was updated to include model annotations, ensuring services are correctly configured for activation purposes. These changes collectively improve the system's ability to manage dynamic and scalable deployments.
Which issue(s) this PR fixes
Fixes #362
Special notes for your reviewer
Does this PR introduce a user-facing change?
cc @pacoxu @kerthcet