Skip to content

feat: support configuring init container image #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

rudeigerc
Copy link
Member

What this PR does / why we need it

This pull request supports configuring the init container image via init-container-image in config.data.

Which issue(s) this PR fixes

Closes #350

Special notes for your reviewer

Please note that only integration tests have been implemented. I think unit tests could be appended after #434 is merged.

Does this PR introduce a user-facing change?

Support configuring the init container image via `init-container-image` in the global configuration.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jun 6, 2025
@InftyAI-Agent InftyAI-Agent requested review from kerthcet June 6, 2025 14:54
@rudeigerc rudeigerc force-pushed the feat/init-container-image branch 3 times, most recently from 70861f4 to 621c32d Compare June 6, 2025 16:58
@kerthcet
Copy link
Member

kerthcet commented Jun 7, 2025

/kind feature

Will continue the review work later.

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jun 7, 2025
@kerthcet
Copy link
Member

we need to solve the conflicts first.

@rudeigerc
Copy link
Member Author

@kerthcet Got it. I'll fix the conflicts first and then complement the related unit tests.

@rudeigerc rudeigerc force-pushed the feat/init-container-image branch 3 times, most recently from 8ea73a9 to 37925eb Compare June 17, 2025 15:44
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

@googs1025
Copy link
Member

@rudeigerc any updated?

@rudeigerc
Copy link
Member Author

@googs1025 Thanks for the reminder. I am out of bandwidth recently, but I will try to make an update this weekend.

@rudeigerc rudeigerc force-pushed the feat/init-container-image branch from 37925eb to 0552846 Compare June 29, 2025 13:42
@rudeigerc
Copy link
Member Author

I've updated the test cases by migrating them to ValidateConfigmap() and added a validation function to validate the global configmap, thereby avoiding the empty initContainerImage.

/cc @kerthcet @googs1025

@InftyAI-Agent InftyAI-Agent requested a review from kerthcet June 29, 2025 13:50
@rudeigerc rudeigerc force-pushed the feat/init-container-image branch from 0552846 to ac82e18 Compare June 29, 2025 14:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: rudeigerc <[email protected]>
@rudeigerc rudeigerc force-pushed the feat/init-container-image branch from ac82e18 to 06214ad Compare June 29, 2025 14:47
@googs1025
Copy link
Member

/lgtm
thanks for this 😄

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Jun 30, 2025
@kerthcet
Copy link
Member

/approve

Thanks @rudeigerc

@InftyAI-Agent InftyAI-Agent added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@InftyAI-Agent InftyAI-Agent merged commit dbdb8c9 into InftyAI:main Jun 30, 2025
20 checks passed
@rudeigerc rudeigerc deleted the feat/init-container-image branch July 1, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can this initcontainer image be configurable?
4 participants