Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdesktop 984 implementation of app self restarter causing issues with (un)installer #183

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

herve-er
Copy link
Contributor

@herve-er herve-er commented Jun 20, 2024

The implementation of the new App self-restarter is problematic for the installer/uninstaller. The installer/uninstaller needs to kill the app, but the self-restarter causes the app to restart immediately, which is breaking the installer/uninstall process.

Steps to Reproduce:

  1. Launch kDrive App (a version with the self-restarter ie: branch develop)
  2. Run the installer or uninstaller.
  3. Let it attempt to kill the app.
  4. Observe the app restarting immediately due to the self-restarter.

Expected Result:

The app should remain closed when the installer or uninstaller kills it, allowing the update process to complete successfully.

Task List:

  • Fix on Windows
  • Check if the issue is present on Linux
    • Fix on Linux (Not concerned)
  • Check if the issue is present on macOS (it is)

@herve-er herve-er marked this pull request as ready for review June 20, 2024 07:28
@herve-er herve-er requested a review from a team as a code owner June 20, 2024 07:28
@herve-er herve-er marked this pull request as draft June 20, 2024 07:28
@herve-er herve-er changed the title Kdesktop 984 implementation of app self restarter causing issues with updater Kdesktop 984 implementation of app self restarter causing issues with (un)installer Jun 20, 2024
@herve-er
Copy link
Contributor Author

herve-er commented Jul 2, 2024

@ClementKunz will provide a fix for the mac uninstaller.

Copy link

sonarcloud bot commented Jul 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants