Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdesktop 887 implement log upload #139

Merged
merged 133 commits into from
Jul 23, 2024

Conversation

herve-er
Copy link
Contributor

@herve-er herve-er commented May 29, 2024

Summary:

Implement a dedicated route for user log uploads using the existing large file upload mechanism.

Details:

  • Implementation Reuse: The new route leverages the same mechanism as the current large file upload (UploadSession). Thus, the existing implementation was adapted for the new route.

  • AbstractUploadSession Class: To streamline the process, I created an AbstractUploadSession class, from which both UploadSessionStandard and UploadSessionLog are derived. This was necessary because many features in UploadSession are not required for log uploads.

  • Session Management: Currently, in-progress sessions are stored in the syncDb to enable cancellation in case of an app crash. Since the log upload isn't linked to a specific syncDb and only one log upload can occur at a time, the uploadSessionToken is now stored in the appState table (parmsDb) (for UploadSessionLog only, UploadSessionStandard still unchanged)

For a visual representation, please refer to the UML diagram of the new upload session implementation: UML Diagram

@herve-er herve-er marked this pull request as ready for review May 29, 2024 09:50
@herve-er herve-er requested a review from a team as a code owner May 29, 2024 09:50
@herve-er herve-er marked this pull request as draft May 29, 2024 09:50
Copy link

sonarcloud bot commented Jul 23, 2024

@ClementKunz ClementKunz merged commit 7b1c3b4 into develop Jul 23, 2024
6 checks passed
@ClementKunz ClementKunz deleted the KDESKTOP-887-Implement-new-log-upload-route branch July 23, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants