Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose response headers in InfluxDBError #108

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Sep 9, 2024

Proposed Changes

  • add helper method to get response headers in InfluxDBError
  • add tests of this new functionality
  • in examples add config.py with Config class to centralize resolution of environment variables usable in examples
  • fix cloud_dedicated_write.py which used outdated import of write_options
  • add example of working with response header values on write

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.12%. Comparing base (0925d5c) to head (66ae494).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   55.08%   55.12%   +0.04%     
==========================================
  Files          33       33              
  Lines        2046     2048       +2     
==========================================
+ Hits         1127     1129       +2     
  Misses        919      919              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar added this to the 0.9.0 milestone Sep 10, 2024
@karel-rehor karel-rehor merged commit 9d92767 into main Sep 10, 2024
14 checks passed
@karel-rehor karel-rehor deleted the feat/httpErrorHeader branch September 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants