-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define global TLSVersion in IdSSL #281
base: master
Are you sure you want to change the base?
Conversation
this allows to have one set of SSL versions for all SSL IO handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with moving these types into the IdSSL.pas unit. But rather than removing them from the IdSSLOpenSSL.pas unit and risk breaking any existing user code, I would leave them in the IdSSLOpenSSL.pas unit for now and have them alias the new types in IdSSL.pas.
Default value for user code should be tlsvTLS_flexible: "The actual protocol version used will be negotiated to the highest version mutually supported by the client and the server." https://www.openssl.org/docs/man1.1.1/man3/TLS_method.html
I've reverted the changes and called the type TLS versions as this is more appropriate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming TIdSSLVersion/s
to TIdTLSVersion/s
is one thing, but I don't see the need for an explicit tlsvTLS_flexible
value at all. Enabling multiple TLS versions at a time should imply the use of "flexible" internally. Just as for OpenSSL, enabling multiple SSL/TLS versions at a time uses SSLv23/TLSMethod internally. And by removing the SSL versions from the enum, the enum can no longer be used with TIdSSLIOHandlerSocketOpenSSL
since SSLv2/v3 still need to be supported for OpenSSL 1.0.2 and earlier. Yes, there are still some systems using those old versions. Only OpenSSL 1.1.x drop SSLv2/v3 completely.
Firstly I named it |
this allows to have one set of TLS versions for all SSL/TLS IO handler