Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add default role and permission #24

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Feat/add default role and permission #24

merged 6 commits into from
Jan 10, 2025

Conversation

chintansakhiya
Copy link
Member

@chintansakhiya chintansakhiya commented Jan 6, 2025 •
edited
Loading

Fixes Issue

Proposed Changes

This pull request introduces the following updates:

  1. Added Role, RoleBinding, ClusterRole, and ClusterRoleBinding configurations to every cluster.
  2. Referenced permissions from issue doc: manage role-permission #21.
  3. Implemented validation logic for both the cluster configuration file and the role configuration file.

Checklist

Please ensure the following items are checked before approving this PR:

  • Code adheres to the project's style guide.
  • Documentation updates are required for this change.
  • Documentation has been updated accordingly.
  • All new and existing tests have been successfully executed.
  • The PR does not include any plagiarized content.
  • The title of the PR accurately summarizes the proposed changes.

@chintansakhiya chintansakhiya self-assigned this Jan 6, 2025
@chintansakhiya chintansakhiya changed the title Feat/add default role Feat/adddefault role and permission Jan 6, 2025
@chintansakhiya chintansakhiya marked this pull request as ready for review January 6, 2025 06:43
@chintansakhiya chintansakhiya changed the title Feat/adddefault role and permission Feat/add default role and permission Jan 6, 2025
munir131
munir131 reviewed Jan 9, 2025
View reviewed changes
pkg/proxy/rbac/rbac.go
rbacvalidation "k8s.io/kubernetes/pkg/registry/rbac/validation"
)

var defalutRole = map[string]v1.PolicyRule{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chintansakhiya We should mention those role in documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a new PR for Doc.

@chintansakhiya chintansakhiya merged commit 10ef2d9 into master Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munir131 munir131 munir131 approved these changes

Assignees

@chintansakhiya chintansakhiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task: add default role to every cluster
2 participants
@chintansakhiya @munir131