Feat support 1.21.6 and change to JSON format #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: convert nbt into readable json binary
NgLoader
force-pushed
the
feat-support-1_21_6
branch
from
0698476 to
2f64594
Compare
feat: added migrate command for converting all existing backpacks at once fix: giveUnsueableContent is now saving after the payer recived there items
chore: remove unused class
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for version 1.21.6 by converting the existing binary backpack storage into a JSON format. Key changes include updating resource and language configuration files to reflect the new JSON-based storage and migration commands, overhauling data conversion methods in various classes (such as NmsManager implementations and Backpack-related classes), and adding new dependencies & build scripts to support version 1.21.6.
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| zip-plugin/src/main/resources/lang/en_US.yml | Added new migration-related messages with a few spelling inconsistencies. |
| zip-plugin/src/main/java/net/imprex/zip/util/AbstractHttpService.java | Updated JSON-based HTTP response parsing; potential bug in InputStreamReader usage. |
| zip-plugin/src/main/java/net/imprex/zip/… (multiple files) | Replaced binary serialization methods with JSON conversion approaches across backpack migration and storage. |
| zip-nms (various versions) | Overhauled itemstack conversion methods and updated logging messages; added version 1.21.6 support. |
| .github/workflows/buildtools.sh | Added build support for version 1.21.6. |
Comments suppressed due to low confidence (1)
zip-nms/zip-nms-v1_21_R5/src/main/java/net/imprex/zip/nms/v1_21_R5/ZipNmsManager.java:147
- Fix the spelling errors in the log message: 'shoudt' should be 'should' and 'manuel' should be 'manually'.
// something went wrong !? maybe user modified it him self
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary storage system has been migrated to a JSON-based format.
Description
The previous binary storage format has been replaced with a new JSON format.
Additionally, the file names now end with .json, making it possible to detect whether a file is in binary or JSON format.
A "Convert All" command was also implemented, allowing users to convert all backpacks at once.
Version support for 1.21.6 has also been added.
Related Issue
#41 Can't open backpack anymore
#3 Linking multiply Items at the same time
How Has This Been Tested?
Types of Changes