Add const qualifiers to nk_allocator in more places.
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nk_allocatorstruct consists of 3 fields,userdata(application-specified ptr),alloc(allocate function), andfree(deallocate function). None of these are modified once provided by the library user as far as I can tell, so it should be safe to make this structconstin all API parameters.Since stb-truetype uses a
void*for allocation data, a cast is necessary. But, since thenk_stbtt_malloc/nk_stbtt_freeimplementations don't modify thenk_allocator(as the potentially mutable allocator is stored indirectly innk_allocator.userdata), this should be fine as well.