Fix undefined behavior in strncpy() call
#595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strncpy()`'s pointer parameters are marked `restrict`, but when `file_browser_reload_directory_content()` was being called to reload the directory it already had open, it would try to copy its path buffer to itself, causing undefined behavior.
RobLoach
reviewed
Jan 22, 2024
RobLoach
approved these changes
Jan 22, 2024
RobLoach
reviewed
Mar 21, 2024
RobLoach
approved these changes
Mar 21, 2024
RobLoach
reviewed
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strncpy()'s pointer parameters are markedrestrict, but whenfile_browser_reload_directory_content()was being called to reload the directory that was currently open:it would try to copy its path buffer to itself, causing undefined behavior. The solution uses
memmove(), which can handle overlapping pointers.Found with Address Sanitizer.