-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing #455 (D3D12 Backend) #487
base: master
Are you sure you want to change the base?
Conversation
So here we go... tried to fix a bug that was not a bug... found another one and fixed it (Changes to D3D12 regarding resource states on upload heaps)... Added a note for the first bug... |
@dumblob can you please take a look at this |
/* | ||
* === IMPORTATE NOTE FOR D3D12 === | ||
* | ||
* Due to a bug in the Windows SDK that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please define/describe shortly the bug in the comment so that it is grep
pable. Then I will merge. Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and maybe squash the commits - it is a small change we could keep together 😉.
- Using ID3D12DescriptorHeap_GetGPUDescriptorHandleForHeapStart now again as intended (I don't know why at some point of time MSFT had this function the way it was used previously...) Revert "Fixed compiler warnings" ... well it had a reason why I did what I did ... This reverts commit 97c7a6b. Fixed a bug with modern directx versions added note for the winsdk issue
PR on the process of
fixingissue #455Issues with
ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStart
and a crashing application in D3D12 Backend. Issue will only apear on old versions of the windows SDK