Enrich api proposals #278
Merged
Enrich api proposals #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#277
Added a new storage item
ProjectInVotingas an api helper so we dont need to blindly interate overRounds.Test added to ensure state is cleaned up alright.
The new api now returns
Project, ImmutableindividualVotes, DisputeVotes, MilestonesInVotingRound
DisputeVotes is a wrapper around
pallet_dispute::BoundedVotesso i can easily call encode on it.MilestonesInVoting round is just a vector of
MilestoneKey.If you want to get the vote weight. you can look this up in project contributions as the contribution is the same as the vote weight.
Migration
No migration is required however current projects in voting rounds wont show in MIlestonesInVotingRound until resubmission .