Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocolli di comunicazione #196

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Protocolli di comunicazione #196

wants to merge 19 commits into from

Conversation

allevo
Copy link
Contributor

@allevo allevo commented Jan 13, 2024

Fix #153

@allevo
Copy link
Contributor Author

allevo commented Jan 13, 2024

Finalizzata la draft durante il https://img.shields.io/badge/%E2%9D%A4%EF%B8%8F-open%20source%20saturday-F64060.svg

guizzo
guizzo requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@guizzo guizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allevo Mi sono permesso di farti review e piazzare qualche suggestions qua e là.

Per la maggiore sono semplici typo, salvo un paio di casi (che all'atto pratico si traduce in una singola "problematica") in cui ho effettivamente dei dubbi.

Sentiti libero di rifiutare ciò che ritieni opportuno, qualora non ti piacesse 🤗

docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
@Cadienvan
Copy link
Member

@allevo preferisci spostarla in draft in attesa di inserire i due protocolli mancanti?

@allevo allevo marked this pull request as draft January 23, 2024 08:31
@Cadienvan
Copy link
Member

@allevo che ne dici se ci occupiamo io e Brian dell'FTP così poi ce la confermi e mandiamo in revisione?

@allevo
Copy link
Contributor Author

allevo commented Jun 13, 2024

@Cadienvan yes va bene!

@Cadienvan
Copy link
Member

@allevo come mi hai comunicato in privato non scrivo nulla e aspetto una tua stesura del pezzo mancante!!

@allevo allevo force-pushed the add/protocolli-di-comunicazione branch from c0f1957 to 186c9db Compare August 8, 2024 13:24
@allevo allevo marked this pull request as ready for review August 8, 2024 14:41
@allevo allevo requested a review from guizzo August 8, 2024 14:56
guizzo
guizzo requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@guizzo guizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @allevo 👋

Giusto un paio di suggestions qua e là, dopodiché mi sembra davvero un ottimo contenuto 👍

docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
Cadienvan
Cadienvan previously approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@Cadienvan Cadienvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanta roba! Un capitolo fondamentale in un libro come questo! Mi torna molto il contenuto dell'FTP! Attendo il check sul commento di Simone ma nel frattempo approvo!

@guizzo
Copy link
Member

guizzo commented Sep 6, 2024

Ciao @allevo 👋

Per caso riesci a dare un feedback qui e qui? Così magari una volta smarcate quelle due suggestions richiediamo reviews e finalmente riusciamo a portare dentro anche quest'ottimo contenuto!

@allevo
Copy link
Contributor Author

allevo commented Sep 6, 2024

Ciao @guizzo grazie per il ping, me l'ero persi!

guizzo
guizzo previously approved these changes Sep 6, 2024
View reviewed changes
guizzo
guizzo previously approved these changes Sep 6, 2024
View reviewed changes
serenasensini
serenasensini reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@serenasensini serenasensini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho segnalato qualche refuso e qualche frase che non suonava, ma nulla di incredibile.

Uno dei capitoli migliori finora, e che avrei decisamente voluto poter leggere ai tempi dell'università. Complimenti per il lavoro!

docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
ugho16
ugho16 previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@ugho16 ugho16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corretto qualche piccolo refuso

docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
@allevo @ugho16 @serenasensini
Apply suggestions from code review
0b1ad0d 
Co-authored-by: Paolo Martinoli <[email protected]>
Co-authored-by: Serena Sensini <[email protected]>
@allevo allevo dismissed stale reviews from ugho16 and guizzo via 0b1ad0d September 6, 2024 15:24
Cadienvan
Cadienvan previously approved these changes Sep 6, 2024
View reviewed changes
ugho16
ugho16 previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ugho16 ugho16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corretto un ultimo refuso

docs/it/protocolli-di-comunicazione.md Outdated Show resolved Hide resolved
@allevo allevo dismissed stale reviews from ugho16 and Cadienvan via 14a15f1 September 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadienvan Cadienvan Cadienvan approved these changes

@corradopetrelli corradopetrelli Awaiting requested review from corradopetrelli

@Mik23mik Mik23mik Awaiting requested review from Mik23mik

@guizzo guizzo Awaiting requested review from guizzo

@serenasensini serenasensini Awaiting requested review from serenasensini

@ugho16 ugho16 Awaiting requested review from ugho16

@eppak eppak Awaiting requested review from eppak

@storrisi storrisi Awaiting requested review from storrisi

@AngeloAvv AngeloAvv Awaiting requested review from AngeloAvv

@gregoriopalama gregoriopalama Awaiting requested review from gregoriopalama

@giuppidev giuppidev Awaiting requested review from giuppidev

@akelity akelity Awaiting requested review from akelity

@fulgido fulgido Awaiting requested review from fulgido

@devnuli devnuli Awaiting requested review from devnuli

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🆕]: Protocolli di comunicazione
7 participants
@allevo @Cadienvan @guizzo @serenasensini @corradopetrelli @Mik23mik @ugho16