Added the posibility to mark data as safe #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leaning to improve speed when needed
|
How much does this improve performance? XSS checks against JSON don't really make sense til decoded, the other fields you could just do is_numeric, and then for the search you'd want XSS checking but otherwise... |
|
I don't have the exact values right now but from what I recall, there was an increase from 10 seconds to 2 seconds loading time when having a lot of data. And by using xhprof I found that the XSS cleaning method was being called almost 300.000 times and was the main cause for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to bypass Codeigniter xss cleaning to improve speed when needed