Update grid overview topic to v19 #1563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrustev
commented
May 22, 2025
| ``` | ||
|
|
||
| > **Note**: | ||
| >Whenever a header template is used along with grouping/moving functionality the column header area becomes draggable and you cannot access the custom elements part of the header template until you mark them as not draggable. Example below. |
There was a problem hiding this comment.
Has been fixed and no longer required.
mddragnev
requested changes
May 29, 2025
| @@ -788,7 +719,7 @@ public smallViewTemplate = (ctx: IgcCellTemplateContext) => { | |||
| ``` | |||
|
|
|||
| ```tsx | |||
| <IgrGrid> | |||
| <IgrGrid ref={grid}> | |||
There was a problem hiding this comment.
The normalViewTemplate and smallViewTemplate snippets have class instead of className set. Also, they are using ctx.dataContext.cell.value which is no longer the case and should be ctx.cell.value
| @@ -1043,7 +976,7 @@ function fetchData(url: string): void { | |||
| .then(data => onDataLoaded(data)); | |||
| } | |||
| function onDataLoaded(jsonData: any[]) { | |||
| gridRef.current.data = jsonData; | |||
| grid.current.data = jsonData; | |||
There was a problem hiding this comment.
Should we show this with state instead of using the ref. Probably, the better react-ish way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.