Skip to content

refactor(grid-summary): remove redundant code and colors #15828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -76,7 +76,7 @@
"@types/source-map": "0.5.2",
"express": "^4.21.1",
"fflate": "^0.8.1",
"igniteui-theming": "^18.0.1",
"igniteui-theming": "^18.0.2",
"igniteui-trial-watermark": "^3.0.2",
"lodash-es": "^4.17.21",
"rxjs": "^7.8.2",
Original file line number Diff line number Diff line change
@@ -12,7 +12,6 @@

/// @param {Map} $schema [$light-material-schema] - The schema used as basis for styling the component.
/// @param {Color} $background-color [null] - The summaries background color is inherited form igx-grid__tfoot
/// @param {Color} $focus-background-color [null] - The background color when a summary item is on focus.
/// @param {Color} $label-color [null] - The summaries label color.
/// @param {Color} $result-color [null] - The summaries value/result color.
/// @param {Color} $border-color [null] - The summaries border color.
@@ -32,7 +31,6 @@
$schema: $light-material-schema,

$background-color: null,
$focus-background-color: null,
$label-color: null,
$result-color: null,
$border-color: null,
@@ -74,7 +72,6 @@
name: $name,
selector: $selector,
background-color: $background-color,
focus-background-color: $focus-background-color,
label-color: $label-color,
result-color: $result-color,
border-color: $border-color,
@@ -131,15 +128,6 @@
overflow: hidden;
outline-style: none;

&::after {
position: absolute;
inset: 0;
}

&:focus::after {
background: var-get($theme, 'focus-background-color');
}

@if $variant == 'indigo' {
border-top: rem(1px) solid var-get($theme, 'border-color');
}
Original file line number Diff line number Diff line change
@@ -24,15 +24,6 @@ $_theme: $material;
overflow: hidden;
outline-style: none;

&::after {
position: absolute;
inset: 0;
}

&:focus::after {
background: var-get($_theme, 'focus-background-color');
}

@include e(item) {
display: flex;
align-items: center;