chore(*): updating to ng 20 #15819
chore(*): updating to ng 20 #15819
Conversation
…igniteui-angular into sstoychev/update-to-20
…igniteui-angular into sstoychev/update-to-20
…igniteui-angular into sstoychev/update-to-20
| @@ -151,7 +151,7 @@ describe('IgxGrid - Cell component #grid', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Cells in virtualized grid ', () => { | |||
| xdescribe('Cells in virtualized grid ', () => { | |||
There was a problem hiding this comment.
@ChronosSF We should log a task to investigate this, try enabling part of the suite at least to identify the issue
| const iconName = collapsed ? 'expand_more' : 'expand_less'; | ||
| expect(button.getAttribute('ng-reflect-icon-name')).toMatch(iconName); |
There was a problem hiding this comment.
While the grid reflect checks are silly, this one doesn't seem to be somewhat reasonable check the correct icon is shown and there doesn't seem to be other checks. Perhaps it should be re-done with fixture query with the icon component and directly check it's set collection + name.
| public visitComponent(component: Component, context: any) { | ||
|
|
||
| } | ||
|
|
||
| public visitDirective(directive: Directive, context: any) { | ||
|
|
||
| } |
There was a problem hiding this comment.
@Lipata @jackofdiamond5 FYI, in case this can be useful in the future :)
| // const operatorInputGroup = QueryBuilderFunctions.getQueryBuilderOperatorSelect(fix).querySelector('igx-input-group') as HTMLElement; | ||
| // expect(operatorInputGroup.querySelector('igx-icon').attributes.getNamedItem('ng-reflect-name').nodeValue).toEqual('in'); |
There was a problem hiding this comment.
These too, kinda the same approach - still check the icon, get with fixture query for the component and verify name and collection?
There was a problem hiding this comment.
@MayaKirova , please address these comments
damyanpetev
added
squash-merge
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)