Skip to content

fix(igxSplitter): Assign pane props after zone is stable. #15800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 27, 2025

Conversation

MayaKirova
Copy link
Contributor

Closes #15540

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IMinchev64 IMinchev64 self-assigned this Jun 19, 2025
@IMinchev64 IMinchev64 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 19, 2025
Copy link
Contributor

@IMinchev64 IMinchev64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the splitter does indeed generate dynamically and the error is gone, however, I noticed that the splitter bars are initially positioned incorrectly (after the panes). If I try to move one of the bars then they get positioned properly. See attached screenshot:

image

@MayaKirova MayaKirova requested a review from IMinchev64 June 20, 2025 09:10
@MayaKirova
Copy link
Contributor Author

It seems that the splitter does indeed generate dynamically and the error is gone, however, I noticed that the splitter bars are initially positioned incorrectly (after the panes). If I try to move one of the bars then they get positioned properly. See attached screenshot:

image

HostBinding should reflect the order correctly now.

@IMinchev64 IMinchev64 added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 23, 2025
@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jun 26, 2025
@dkamburov dkamburov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 27, 2025
@dkamburov dkamburov merged commit 1b47d14 into 19.2.x Jun 27, 2025
5 checks passed
@dkamburov dkamburov deleted the mkirova/fix-15540-19.2.x branch June 27, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
splitter version: 19.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants