Skip to content

Improve Component Themes #15729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Conversation

didimmova
Copy link
Contributor

Closes #15443

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

didimmova and others added 30 commits March 10, 2025 15:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…omponent-themes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(badge): improve badge theme

* feat(avatar, badge): use css vars to calculate contrast dynamically

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(expansion-panel): improve expansion-panel theme

* feat(expansion-panel): use meta from schemas

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…15643)

* feat(dialog): update dialog theme to use adaptive-contrast function

* feat(dialog): update using meta from schemas

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(combo): improve combo theme

* feat(combo): update material focus background color of the toggle button

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(action-strip): update text contrast function

* remove meta

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(bottom-nav): improve bottom-nav theme

* feat(bottom-nav): use background css var

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(banner): improve banner theme

* feat(banner): use css vars

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* feat(tree): improve tree theme

* feat(tree): add logic for disabled state

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…omponent-themes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@didimmova didimmova marked this pull request as ready for review May 7, 2025 07:46
@didimmova didimmova added ❌ status: awaiting-test PRs awaiting manual verification ✨ themes labels May 7, 2025
@didimmova didimmova requested a review from simeonoff May 7, 2025 07:47
didimmova and others added 13 commits May 7, 2025 17:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
didimmova and others added 3 commits May 27, 2025 10:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some conflict artifacts in elements I assume are not intended:

@didimmova didimmova requested a review from damyanpetev June 10, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ themes ❌ status: awaiting-test PRs awaiting manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Improve component theme functions
3 participants