[wpeview] Use mangled C++ names for entrypoints #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applying this patch will allow to completely remove one patch applied with Cerbero on top of WPE WebKit. The aim is to use vanilla WPE WebKit without needing patching for Android. |
neodesys
approved these changes
Mar 21, 2025
|
I'll send a separate patch to fix the lint errors, then rebase this and re-run the CI. |
Use the C++ mangled named for the WebKit::WebProcessMain() and WebKit::NetworkProcessMain() functions, instead of the ones with the android_ prefix. This will allow dropping a patch on top of vanilla WPE WebKit that added the android_WebProcess_main() and android_NetworkProcess_main() symbols. The only additional thing those wrappers did was sending the list of arguments to the Android log, for debugging purposes, but that may be re-added at a later time inside initializeNativeMain() without needing to modify WPE WebKit.
aperezdc
force-pushed
the
aperezdc/use-libwpewebkit-mangled-symbols
branch
from
ed34eb9 to
823e508
Compare
aperezdc
added a commit
to Igalia/wpe-android-cerbero
that referenced
this pull request
Mar 26, 2025
This is the latest release in the 2.46.x stable series, which contains security fixes. While at it, drop the patch to add unmangled entry points for the Network and Web processes now that they are not needed anymore since Igalia/wpe-android#184
aperezdc
added a commit
to Igalia/wpe-android-cerbero
that referenced
this pull request
Mar 26, 2025
This is the latest release in the 2.46.x stable series, which contains security fixes. While at it, drop the patch to add unmangled entry points for the Network and Web processes now that they are not needed anymore since Igalia/wpe-android#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the C++ mangled named for the
WebKit::WebProcessMain()andWebKit::NetworkProcessMain()functions, instead of the ones with theandroid_prefix.This will allow dropping a patch on top of vanilla WPE WebKit that added the
android_WebProcess_main()andandroid_NetworkProcess_main()symbols. The only additional thing those wrappers did was sending the list of arguments to the Android log, for debugging purposes, but that may be re-added at a later time insideinitializeNativeMain()without needing to modify WPE WebKit.