Skip to content

Install VSCodium and make host .application file #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Install VSCodium and make host .application file #86

wants to merge 1 commit into from

Conversation

justinmichaud
Copy link
Collaborator

@justinmichaud justinmichaud commented Jan 16, 2025 •
edited
Loading

  • Allow installing VSCodium
  • Add helpful clangd default settings
  • Make VSCode .application file by default

TingPing
TingPing requested changes Jan 16, 2025
View reviewed changes
@justinmichaud
Copy link
Collaborator Author

Thank you for the review, everything has been updated!

TingPing
TingPing reviewed Jan 23, 2025
View reviewed changes
justinmichaud
justinmichaud commented Feb 13, 2025
View reviewed changes
@justinmichaud
- Allow installing VSCodium
ff933c8 
- Add helpful clangd default settings
- Make VSCode .application file by default
@justinmichaud
Copy link
Collaborator Author

I have simplified this PR:

  • We always use the tar version of vscode or vscodium, so that this can work for armv7, arm64 and x64
  • Only the settings that were not contentious are set
  • I got rid of a bunch of duplicated code.

This is tested and working on arm64 and armv7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingPing TingPing TingPing requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinmichaud @TingPing