Breaking changes in modernize code #158
Open
BastianLedererIcinga wants to merge 6 commits intomainfrom
Open
Conversation
This change required adjustments to the following dependencies:
icingadb-web:
- library/Icingadb/Model/ServicegroupSummary
- library/Icingadb/Model/Hostgroupsummary
icingaweb2-module-nagvis:
- library/Nagvis/Model/HostgroupSummary
- library/Nagvis/Model/ServicegroupSummary
This change required adjustments to the following dependencies:
icingadb-web:
- library/Icingadb/Model/UnreachableParent/ResultSet
- library/Icingadb/Redis/VolatileStateResults
dependencies-web:
requires no changes but depends on the icingadb-web changes
…ions
This change required adjustments to the following dependencies:
icingadb-web:
- library/Icingadb/Model/CustomvarFlat
- library/Icingadb/Model/Behavior/Bitmask
- library/Icingadb/Model/BehaviorFlattenedObjectVars
- library/Icingadb/Model/Behavior/HasProblematicParent
- library/Icingadb/Model/Behavior/Reroute
x509:
- library/X509/Model/Behavior/ExpressionInjector
notifications-web:
- library/Notifications/Model/Behavior/IcingaCustomVars
- library/Notifications/Model/Behavior/IdTagAggregator
- library/Notifications/Model/Behavior/ObjectTags
kubernetes-web:
- library/Kubernetes/Model/Behavior/Uuid
partnerportal:
- library/Partnerportal/Model/Behavior/AggregatedColumn.php
This change required adjustments to the following dependencies:
icingadb-web:
- library/Icingadb/Model/Behavior/FlattenedObjectVars.php
- library/Icingadb/Model/Behavior/HasProblematicParent.php
icinga-notifications-web:
- library/Notifications/Model/Behavior/IcingaCustomVars.php
- library/Notifications/Model/Behavior/IdTagAggregator.php
- library/Notifications/Model/Behavior/ObjectTags.php
partnerportal:
- library/Partnerportal/Model/Behavior/ActiveContracts.php
- library/Partnerportal/Model/Behavior/NextContractEnd.php
- library/Partnerportal/Model/Behavior/TotalContracts.php
The return type is also added for `Binary::setQuery()`
This change required adjustments to the following dependencies:
notifications-web:
- library/Notifications/Model/Behavior/IdTagAggregator
- library/Notifications/Model/Behavior/ObjectTags
x509:
- library/X509/Model/Behavior/ExpressionInjector
- library/X509/Model/Behavior/Ip
icingadb-web:
- library/Icingadb/Model/Behavior/FlattenedObjectVars
- library/Icingadb/Model/Behavior/HasProblematicParent
BastianLedererIcinga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce breaking type additions that require compatibility changes in modules.
Requires changes to the following files:
icingadb-web:
Nagvis:
dependencies-web:
requires no changes but
library/Dependencies/Data/UnreachableParentResultsdepends on the db-web changesnotifications-web:
x509:
kubernetes-web:
partnerportal:
dependencies:
Icinga/icinga-notifications-web#403
Icinga/icingadb-web#1340
Icinga/icingaweb2-module-nagvis#72
Icinga/icingaweb2-module-x509#263
Icinga/icinga-kubernetes-web#171
https://git.icinga.com/icingaweb2/icingaweb2-module-partnerportal/-/merge_requests/139