CMake: remove logrotate version detection #10540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used to detect the presence of version 3.8.0 which introduced the "su" config option[^1]. It was releases in 2011, so I'd say it's time that we can just assume that it's supported. Additionally, this has a bit of a security impact as it defaults to not using the "su" option, which means that logrotate will do more than necessary as root. This happened with our packages as these were built without logrotate being installed, which caused the version detection to fail. Just assuming the new version here instead of adding it as a non-obvious build dependency should be the more robust fix. [^1]: https://github.com/logrotate/logrotate/blob/r3-8-0/CHANGES#L6-L8
|
Note: I just verified whether the So it's probably more of a "clean up legacy stuff" PR and doesn't have a real security impact. According to the changelog, it was added to allow safe(r) operations inside directories that are group/world writable and the changelog also says that logrotate will now skip such directories. |
julianbrost
added
the
core/quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used to detect the presence of version 3.8.0 which introduced the "su" config option1. It was releases in 2011, so I'd say it's time that we can just assume that it's supported.
Additionally, this has a bit of a security impact as it defaults to not using the "su" option, which means that logrotate will do more than necessary as root. This happened with our packages as these were built without logrotate being installed, which caused the version detection to fail. Just assuming the new version here instead of adding it as a non-obvious build dependency should be the more robust fix.
(Draft as I have to build proper packages for testing this first.)
refs #10527
Footnotes
https://github.com/logrotate/logrotate/blob/r3-8-0/CHANGES#L6-L8 ↩