-
Notifications
You must be signed in to change notification settings - Fork 597
docs: Remove 'queue' parameter requirement from event stream document… #10495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Egor-OSSRevival
|
Signed |
@cla-bot check |
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Egor-OSSRevival
|
@cla-bot check |
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @Egor-OSSRevival
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR.
The change looks good so far and API requests sill sending the queue
parameter should still work.
Someone else should take a look at the CLA bot thingy.
Thank you, I have signed for two times now(one yesterday and one today) and still got this message |
@cla-bot check |
AUTHORS
Outdated
Yonas Habteab <[email protected]> | ||
Zachary McGibbon <[email protected]> | ||
Zoltan Nagy <[email protected]> | ||
Egor Kovalchuk <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you keep the file sorted alphabetically?
Fix: Remove queue parameter requirement from event stream documentation
This commit addresses the discrepancy between the Event Stream API's behavior and its documentation regarding the queue parameter.
The queue parameter was previously documented as a required, unique identifier for clients sharing the same event types and filter. However, the underlying code only checked for its presence without implementing any of the documented logic, as this was removed in a prior change (#7088).
To resolve this, the following changes have been made:
lib/remote/eventshandler.cpp: The check requiring the presence of the queue parameter has been removed.
doc/12-icinga2-api.md: The documentation has been updated to remove the queue parameter from the list of required parameters for the event stream.