Skip to content

Conversation

Egor-OSSRevival
Copy link

Fix: Remove queue parameter requirement from event stream documentation
This commit addresses the discrepancy between the Event Stream API's behavior and its documentation regarding the queue parameter.

The queue parameter was previously documented as a required, unique identifier for clients sharing the same event types and filter. However, the underlying code only checked for its presence without implementing any of the documented logic, as this was removed in a prior change (#7088).

To resolve this, the following changes have been made:

lib/remote/eventshandler.cpp: The check requiring the presence of the queue parameter has been removed.

doc/12-icinga2-api.md: The documentation has been updated to remove the queue parameter from the list of required parameters for the event stream.

Copy link

cla-bot bot commented Jul 2, 2025

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Egor-OSSRevival

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@Egor-OSSRevival
Copy link
Author

Signed

@oxzi oxzi linked an issue Jul 3, 2025 that may be closed by this pull request
@oxzi
Copy link
Member

oxzi commented Jul 3, 2025

@cla-bot check

Copy link

cla-bot bot commented Jul 3, 2025

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Egor-OSSRevival

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@Egor-OSSRevival
Copy link
Author

@cla-bot check

Copy link

cla-bot bot commented Jul 3, 2025

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Egor-OSSRevival

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR.

The change looks good so far and API requests sill sending the queue parameter should still work.

Someone else should take a look at the CLA bot thingy.

@Egor-OSSRevival
Copy link
Author

Thank you, I have signed for two times now(one yesterday and one today) and still got this message

@bobapple
Copy link
Member

bobapple commented Jul 4, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Jul 4, 2025
@bobapple bobapple removed their assignment Jul 4, 2025
Al2Klimov
Al2Klimov previously approved these changes Jul 4, 2025
@Al2Klimov Al2Klimov dismissed their stale review July 4, 2025 08:03

GHA failed

AUTHORS Outdated
Yonas Habteab <[email protected]>
Zachary McGibbon <[email protected]>
Zoltan Nagy <[email protected]>
Egor Kovalchuk <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you keep the file sorted alphabetically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event Stream API: Dysfunctional "queue" Parameter

4 participants