write tests and fixed some bugs. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osherdp
requested changes
Sep 28, 2020
IamShobe
reviewed
Sep 28, 2020
There was a problem hiding this comment.
match should be converted to a class :)
consider using different name for match in method:
target, dest, src
and methods:
target.is_root()
target.is_directory()
target.is_file()
target.is_bucket()
properties:
target.relative_path
target.bucket
target.prefix
target.filename
opened task #10
|
DONT ADD NEW THINGS TO THIS BRANCH AS ITS DIFFICULT ALREADY READING ALL. |
AsafSH6
reviewed
Oct 2, 2020
| self._extract_metadata(details.metadata) | ||
|
|
||
| metadata = { | ||
| "is_dir": details.is_dir, |
There was a problem hiding this comment.
Where is_dir was added to the details? I can't find it
There was a problem hiding this comment.
minio's stat_object return data like is_dir and created_at modified_at and more.
list_objects add this data to the object aswell.
This was referenced Oct 4, 2020
IamTugy
force-pushed
the
feature/write-docstings-and-pritty-the-code
branch
from
8384619
to
98b84d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.