Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESSI-875] bulkrax 5 upgrade #597

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[ESSI-875] bulkrax 5 upgrade #597

wants to merge 25 commits into from

Conversation

aploshay
Copy link
Contributor

@aploshay aploshay commented Jan 12, 2024

Upgrades from bulkrax 1.0.2 to 5.5.1.

Work and FileSet ingest is working in my local environment, with some outstanding issues.

Known Issues:

  • ** FileSet <-> Work association**: The various import jobs aren't being sequenced to run in the necessary order (at least, in my local environment), so I'm finding I have to run the importer once to get the works created (with all the FileSets failing), then re-run it to create all the FileSets. See [bulkrax issue #955](importer tries, fails to create FileSets before Works are persisted (tested in 5.5.1, 7.0.0) samvera/bulkrax#955)~
  • ** Collection creation/association**: I haven't had success ingesting to create a new Collection, or to associate to an existing one -- but I only tried this lightly, and it might be issues of configuration and/or CSV content.
  • METS XML import: dropped, as it is based on XML import, which isn't supported in newer version of bulkrax
  • Ingested nested Works within Works: works, but doesn't display in UI, but that's really a separate issue
  • Exporting: metadata export works, but with access concerns, access restricted to admins and managers, and file export prevented (isn't working, and we don't want it done, anyway)

Temporarily skipped tests:

  • Feature spec for CSV ingest
  • METS XML Entry model spec (parser is still tested)

Regarding configuration change label:

  • requires running database migrations
  • may also require (or benefit from) TBD config changes to bulkrax

Notes on running locally:

  • make sure to run a db:migrate to pick up the bulkrax changes -- the rails server will run without complaint when the migrations are coming from a gem, unlike when they are directly in the repo and it hard stops and tells you to migrate
  • you may run into some issues spinning up the branch; ask me if I had the same problem and what I did to work around it

@aploshay aploshay added the configuration change PR requires config changes label Jan 12, 2024
@aploshay aploshay changed the title [ESSI-875] bulkrax upgrade DRAFT [ESSI-875] bulkrax upgrade May 14, 2024
@aploshay aploshay force-pushed the essi-875_bulkrax_upgrade branch from 56c76ad to ba932fb Compare May 30, 2024 20:57
@aploshay aploshay force-pushed the essi-875_bulkrax_upgrade branch 2 times, most recently from c49692b to 1f429a5 Compare October 1, 2024 16:59
@aploshay aploshay marked this pull request as ready for review October 1, 2024 17:08
@aploshay aploshay marked this pull request as draft November 13, 2024 18:30
@aploshay aploshay force-pushed the essi-875_bulkrax_upgrade branch from 1f429a5 to ce0d8f0 Compare December 17, 2024 22:38
@aploshay aploshay force-pushed the essi-875_bulkrax_upgrade branch from ce0d8f0 to fa7d845 Compare January 10, 2025 20:22
@aploshay aploshay force-pushed the essi-875_bulkrax_upgrade branch from fa7d845 to c7f5a90 Compare January 10, 2025 20:33
@aploshay aploshay marked this pull request as ready for review January 13, 2025 17:10
@aploshay aploshay changed the title DRAFT [ESSI-875] bulkrax upgrade [ESSI-875] bulkrax 5 upgrade Jan 13, 2025
Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by visual inspection.
The downgrade of sidekiq is probably a good thing. While nothing seemed broken, it does warn that sidekiq 7 is not supported on this old stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration change PR requires config changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants