Milestone 9: add devise #9

ITurres · 2023-12-13T21:41:10Z

Pull Request Summary for Milestone 9 Completion

All requirements completed.

Added:

`/app/devise/*`

@ITurres && @demesameneshoa: We have added the devise gem to the project.
We have modified the usual devise files to fit the project needs, that includes:
- modified views. (Updated: now with confirmable)
- modified partials. (Updated: now with confirmable)
- modified controllers.
- modified environments.
- modified routes.
- modified models. (Updated: now with confirmable)
- Added migrations. (Updated: now with confirmable)
- Regenerate schema. (Updated: now with confirmable)
Please see here for further details

`/app/views/layouts/_navbar.html.erb`

@ITurres: I have added a navbar partial to display the app logo and the sign out link as long as the user is logged in.

`/app/views/layouts/_back_button.html.erb`

@ITurres: I have added a back button partial to display a back button as long as the current page is not root.

Modified:

`/README.md`

`/app/models/user.rb`

@ITurres: Apart form the devise modifications, I have added a private set_default_photo method to set a default random photo to the user before creation.
Marked the devise task as completed.

`/app/views/layouts/application.html.erb`

@ITurres: now the navbar partial is being rendered, and the back_button.

`/app/views/shared/_user_card.html.erb

@ITurres: I have modified/added bootstrap classes to the user card.

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

- Modified: Gemfile - Modified: Gemfile.lock - Added: app/views/devise/* - Added: config/initializers/devise.rb - Added: config/locales/devise.en.yml - Added: db/migrate/20231213164642_add_devise_to_users.rb

…ization Implemented Devise authentication and parameter handling in ApplicationController: - Enforced user authentication across the app with `before_action :authenticate_user!`. - Protected against CSRF attacks with `protect_from_forgery with: :exception`. - Implemented strong parameters for user attributes in sign-up, updates, and sign-in.

- Modified: passwords/new.html.erb - Modified: registrations/new.html.erb - Modified: sessions/new.html.erb - Modified: shared/_links.html.erb

…gn-in

- Add Devise - checked.

Shedrack-Sunday

Hello @ITurres 👋

CHANGES REQUIRED ♻️

Impressive work on the project so far👏
You've done extremely well so far in this project, However, there are some adjustments you need to make to move to the next project. 💯

Highlights

Good use of GitHub features ✔️
Nice work with Devise features ✔️
Great work on the Authorization implementation 👏

- Required Changes 🌵

Kindly note the comment i made regarding the issues on enabling the :onfirmable feature to make sure signup is confirmed

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing really improves your application.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Shedrack-Sunday · 2023-12-13T22:19:48Z

app/models/user.rb

+  # Include default devise modules. Others available are:
+  # :confirmable, :lockable, :timeoutable, :trackable and :omniauthable


Kindly enable :confirmable to make it possible to get a confirmation after login 👍

Requirement:

Shedrack-Sunday · 2023-12-13T22:23:03Z

db/migrate/20231213164642_add_devise_to_users.rb

+
+      ## Confirmable
+      # t.string   :confirmation_token
+      # t.datetime :confirmed_at
+      # t.datetime :confirmation_sent_at
+      # t.string   :unconfirmed_email # Only if using reconfirmable


Do well to uncomment this section, to make sure the confirmable configuration works 👍

ITurres · 2023-12-13T23:42:43Z

Holly Molly, we have overlooked that @demesameneshoa ! 🥲

Hi @Shedrack-Sunday! thank you so much for having reviewed this PR! You are right!, We'll fix it right away 🎯
We'll also make sure to modify the views to math the current design.

Thank you again! 🥂

V-Blaze

Hi @ITurres, @demesameneshoa

Approved 🟢 🟢

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

Devise setup correctly 💯
Great communication with reviewer👍
Correct git flow🟢 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ITurres · 2023-12-14T00:26:23Z

Wow great! 🥳. Thank you @V-Blaze! We both wish you a great week! thank you for reviewing the PR.

ITurres and others added 18 commits December 13, 2023 15:13

Feat: Add devise and all its required files

25c2beb

- Modified: Gemfile - Modified: Gemfile.lock - Added: app/views/devise/* - Added: config/initializers/devise.rb - Added: config/locales/devise.en.yml - Added: db/migrate/20231213164642_add_devise_to_users.rb

chore: update 'schema.rb' with new divese migrations

1c11064

Add new layout partial 'navbar'

6fbd91a

feat: render 'lnavbar' partial on 'application' layout

11edc95

feat: added devise attributes for the user model

974c1a2

refactor: users#show view to accomodate the devise users data

f83a2c9

feat: modified development environment to allow localhost on mailing url

9b51d00

Add devise and user association on routes

9b7736b

feat: update all devise views and links markup and styling

29b1c7c

- Modified: passwords/new.html.erb - Modified: registrations/new.html.erb - Modified: sessions/new.html.erb - Modified: shared/_links.html.erb

feat: Add 'sign-out' btn to 'navbar' partial

8ee0ff7

Add new shared partial 'back_button'

e5628a9

remove: 'sign-out' btn from 'user#show' view

8e0a577

feat: Add 'user#set_default_photo' to dynamic add user photos when si…

4752389

…gn-in

styles: modify and add bootstrap classes to 'user_card' partial

6515a96

styles: modify and add bootstrap classes to 'user#show' view

edfc473

linters: resolve rubocop offenses on 'user' model

3f08e25

Docs: Update 'README.md' check complete another future-feature

f167613

- Add Devise - checked.

ITurres added documentation Improvements or additions to documentation enhancement New feature or request UI Views UI labels Dec 13, 2023

ITurres assigned ITurres and demesameneshoa Dec 13, 2023

ITurres marked this pull request as ready for review December 13, 2023 21:58

Shedrack-Sunday suggested changes Dec 13, 2023

View reviewed changes

ITurres added 4 commits December 13, 2023 20:57

feat: Enable 'confirmable' and run confirmable to devise

605a93c

chore: regenerate 'schema' with confirmable entries

36f5324

feat: update 'confirmations#new' view and 'devise/shared/links' partial

9f4adb1

linters: resolve doublequoted ofenses

08a97a1

V-Blaze approved these changes Dec 14, 2023

View reviewed changes

ITurres merged commit 189bf68 into development Dec 14, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Milestone 9: add devise #9

Milestone 9: add devise #9

ITurres commented Dec 13, 2023 •

edited

Loading

Shedrack-Sunday left a comment •

edited by ITurres

Loading

Shedrack-Sunday Dec 13, 2023 •

edited by ITurres

Loading

Shedrack-Sunday Dec 13, 2023 •

edited by ITurres

Loading

ITurres commented Dec 13, 2023

V-Blaze left a comment

ITurres commented Dec 14, 2023

		# Include default devise modules. Others available are:
		# :confirmable, :lockable, :timeoutable, :trackable and :omniauthable

Milestone 9: add devise #9

Milestone 9: add devise #9

Conversation

ITurres commented Dec 13, 2023 • edited Loading

Pull Request Summary for Milestone 9 Completion

Added:

/app/devise/*

/app/views/layouts/_navbar.html.erb

/app/views/layouts/_back_button.html.erb

Modified:

/README.md

/app/models/user.rb

/app/views/layouts/application.html.erb

`/app/views/shared/_user_card.html.erb

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

Shedrack-Sunday left a comment • edited by ITurres Loading

Choose a reason for hiding this comment

CHANGES REQUIRED ♻️

Highlights

- Required Changes 🌵

Optional suggestions

Shedrack-Sunday Dec 13, 2023 • edited by ITurres Loading

Choose a reason for hiding this comment

Requirement:

Shedrack-Sunday Dec 13, 2023 • edited by ITurres Loading

Choose a reason for hiding this comment

ITurres commented Dec 13, 2023

V-Blaze left a comment

Choose a reason for hiding this comment

Approved 🟢 🟢

Highlights

Optional suggestions

ITurres commented Dec 14, 2023

ITurres commented Dec 13, 2023 •

edited

Loading

`/app/devise/*`

`/app/views/layouts/_navbar.html.erb`

`/app/views/layouts/_back_button.html.erb`

`/README.md`

`/app/models/user.rb`

`/app/views/layouts/application.html.erb`

Shedrack-Sunday left a comment •

edited by ITurres

Loading

Shedrack-Sunday Dec 13, 2023 •

edited by ITurres

Loading

Shedrack-Sunday Dec 13, 2023 •

edited by ITurres

Loading