Milestone 2: models associations #2

ITurres · 2023-11-30T00:33:53Z

🚩I have made the following changes to complete Milestone 2

Here is a summary of what has been done

Type of `files` changed/added

In this new Branch, I have ➕ADDED➕ the succeeding *📂 folders and/or **📄 files to complete this milestone requirements

*📂 root/

*📂 app/
```
- I set up all the associations between the models plus each model's custom methods.
```
- **📄 user.rb ➕
  - A method that returns the 3 most recent posts for a given user. This method will also accept an arbitrary number of posts to return, if none is specified, it will default to 3.
- **📄 post.rb ➕
  - A method that updates the posts counter for a user.
  - A method which returns the 5 most recent comments for a given post. This method will also accept an arbitrary number of comments to return, if none is specified, it will default to 5.
- **📄 comment.rb ➕
  - A method that updates the comments counter for a post.
- **📄 like.rb ➕
  - A method that updates the likes counter for a post.

I have ✏️MODIFIED✏️ the succeeding *📂 folders and/or 📄 files**

*📂 root/

**📄 README.md ➕
*📂 db/
- **📄 schema.rb ➕
  - A new schema.rb has been regenerated based on the migration changes.
- *📂 migrate/
  - **📄 20231128225500_create_posts.rb ➕
    - I removed the _id on :author reference at CreatePosts migration for consistency.
  - **📄 20231128225646_create_comments.rb ➕
    - I moved the t.references :post, null: false, foreign_key: true before :user but lately I have set it as it was (after ':user' - see commit history). Keeping their positions consistency as elsewhere.

Thank you for taking the time to review this PR ⭐

If you need additional information or have any questions, please don't hesitate to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to help you out. 🎯

- Add all the required models methods.

Strangeal

Hi @ITurres,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Good PR title ✅
Descriptive PR description ✅
Implement the features ✅
Nice UI design ✅
Professional README template ✅
Correct GitHub workflow ✅
Meaningful Github commits ✅
Correct .github/workflows for linters ✅
Followed best-practices ✅
Well structured project ✅

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Strangeal · 2023-11-30T01:11:37Z

app/models/post.rb

@@ -0,0 +1,13 @@
+class Post < ApplicationRecord
+  belongs_to :author, class_name: 'User', foreign_key: :author_id_id


Great job so far! 👏 You're on the right track with setting up the associations in your models. However, there are a couple of improvements and corrections needed. Let's dive into the review:

In Rails, when you define associations like has_many or belongs_to, Rails automatically assumes the foreign key based on naming conventions unless you explicitly specify it. So, you don't need to add _id in the foreign key names when using the typical Rails naming conventions.

Instead of 👇👇

belongs_to :author, class_name: 'User', foreign_key: :author_id_id

Do this 👇👇

belongs_to :author, class_name: 'User', foreign_key: :author_id

Happy coding!

Strangeal · 2023-11-30T01:18:09Z

app/models/post.rb

+
+  def update_posts_counter
+    author.increment!(:posts_counter)
+  end


Great work on defining the methods for your post model! 😊 To enhance the maintainability and organization of your code, I recommend considering the use of Rails Active Callbacks, specifically after_save, to automatically trigger the update_posts_counter method each time a new post is saved to the database. This approach will help you keep your code clean and ensure that the counter is always up to date without manual intervention.

Below is an example of making use of after_save:

after_save :update_posts_counter def update_posts_counter author.increment!(:posts_counter) end

Keep up the good work! 👍🚀

Hi @Strangeal! Oh, nice 🎯, thank you for the suggestion! I will totally implement it now. 🥂

Strangeal · 2023-11-30T01:21:05Z

app/models/comment.rb

+  def update_comments_counter
+    post.increment!(:comments_counter)
+  end


Hint : Just like I mentioned in my second comment, after_save :update_comments_counter

Strangeal · 2023-11-30T01:21:35Z

app/models/like.rb

+  def update_likes_counter
+    post.increment!(:likes_counter)
+  end


Hint : Just like I mentioned in my second comment, after_save : update_likes_counter

ITurres · 2023-11-30T02:19:09Z

🔴Note: after_save Rails ActiveRecord callback has also been added to Post model. See commit d10a8ec

Shedrack-Sunday

Hi @ITurres 👍
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

Good project organization ✔️
Nice use of Rails features ✔️
Kudus on meeting the requirements as pointed the last time out by the last reviewer 👏

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ITurres · 2023-11-30T02:29:26Z

Hey @Shedrack-Sunday! Cheers for approving the PR 🥂, @Strangeal comments were very helpful. Wish you both a great week! and happy coding 👨🏼‍💻.

ITurres added 6 commits November 29, 2023 20:56

Refactor: move comments ':post' reference to top

7f79928

Refactor: remove '_id' on ':author' reference at 'CreatePosts' migration

273e10f

Refactor: Regenerate 'schema.rb' after class migration refactor

597ed7a

Feat: Add 'User', 'Post', 'Comment', and 'Like' models

3a3e39a

- Add all the required models methods.

Docs: Update 'README.md' check f-feature

776f430

Refactor: move comments ':post' reference back to after ':user'

5b07b92

ITurres self-assigned this Nov 30, 2023

ITurres added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 30, 2023

Strangeal suggested changes Nov 30, 2023

View reviewed changes

ITurres added 2 commits November 29, 2023 23:13

Refactor: remove extra '_id' from 'User' 'author' fk

d10a8ec

Feat: Add Rails ActiveRecord callbacks to Like and Comment models

691166a

Shedrack-Sunday approved these changes Nov 30, 2023

View reviewed changes

ITurres merged commit b71f964 into development Nov 30, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Milestone 2: models associations #2

Milestone 2: models associations #2

ITurres commented Nov 30, 2023 •

edited

Loading

*📂 migrate/

Strangeal left a comment

Strangeal Nov 30, 2023

Strangeal Nov 30, 2023 •

edited by ITurres

Loading

ITurres Nov 30, 2023

Strangeal Nov 30, 2023

Strangeal Nov 30, 2023

ITurres commented Nov 30, 2023 •

edited

Loading

Shedrack-Sunday left a comment

ITurres commented Nov 30, 2023

		@@ -0,0 +1,13 @@
		class Post < ApplicationRecord
		belongs_to :author, class_name: 'User', foreign_key: :author_id_id

Milestone 2: models associations #2

Milestone 2: models associations #2

Conversation

ITurres commented Nov 30, 2023 • edited Loading

🚩I have made the following changes to complete Milestone 2

Here is a summary of what has been done

Type of files changed/added

In this new Branch, I have ➕ADDED➕ the succeeding *📂 folders and/or **📄 files to complete this milestone requirements

*📂 root/

*📂 app/

I have ✏️MODIFIED✏️ the succeeding *📂 folders and/or 📄** files

*📂 root/

*📂 db/

*📂 migrate/

Thank you for taking the time to review this PR ⭐

Strangeal left a comment

Choose a reason for hiding this comment

Highlights

Required Changes ♻️

Optional suggestions

Strangeal Nov 30, 2023

Choose a reason for hiding this comment

Strangeal Nov 30, 2023 • edited by ITurres Loading

Choose a reason for hiding this comment

Below is an example of making use of after_save:

ITurres Nov 30, 2023

Choose a reason for hiding this comment

Strangeal Nov 30, 2023

Choose a reason for hiding this comment

Strangeal Nov 30, 2023

Choose a reason for hiding this comment

ITurres commented Nov 30, 2023 • edited Loading

Shedrack-Sunday left a comment

Choose a reason for hiding this comment

ITurres commented Nov 30, 2023

ITurres commented Nov 30, 2023 •

edited

Loading

Type of `files` changed/added

I have ✏️MODIFIED✏️ the succeeding *📂 folders and/or 📄 files**

Strangeal Nov 30, 2023 •

edited by ITurres

Loading

Below is an example of making use of `after_save`:

ITurres commented Nov 30, 2023 •

edited

Loading