Test

src/FoxIDs.Control/Controllers/Parties/GenericOAuthClientSecretUpPartyController.cs

@@ -38,7 +38,7 @@ public GenericOAuthClientSecretUpPartyController(TelemetryScopedLogger logger, I
                 {
                     return Ok(new Api.OAuthClientSecretSingleResponse
                     {
-                        Info = oauthUpParty.Client.ClientSecret.Length > 20 ? oauthUpParty.Client.ClientSecret.Substring(0, 3) : oauthUpParty.Client.ClientSecret,
+                        Info = oauthUpParty.Client.ClientSecret.GetShortSecret(false),
                     });
                 }
                 else

src/FoxIDs.Control/Controllers/Parties/GenericPartyApiController.cs

@@ -20,7 +20,7 @@ namespace FoxIDs.Controllers
     /// Abstract connection API.
     /// </summary>
     [TenantScopeAuthorize(Constants.ControlApi.Segment.Party)]
-    public abstract class GenericPartyApiController<AParty, AClaimTransform, MParty> : ApiController where AParty : Api.INewNameValue, Api.IClaimTransform<AClaimTransform> where MParty : Party where AClaimTransform : Api.ClaimTransform
+    public abstract class GenericPartyApiController<AParty, AClaimTransform, MParty> : ApiController where AParty : Api.INewNameValue, Api.IClaimTransformRef<AClaimTransform> where MParty : Party where AClaimTransform : Api.ClaimTransform
     {
         private readonly FoxIDsControlSettings settings;
         private readonly TelemetryScopedLogger logger;
@@ -112,7 +112,6 @@ protected async Task<ActionResult<AParty>> Post(AParty party, Func<AParty, Value
 
                 var mUpPartyProfiles = GetMUpPartyProfils(mParty);
 
-                if (!(mParty is UpParty upParty ? await validateModelGenericPartyLogic.ValidateModelExtendedUiAsync(ModelState, upParty, false) : true)) return BadRequest(ModelState);
                 if (!(mParty is UpParty ? validateModelGenericPartyLogic.ValidateModelUpPartyProfiles(ModelState, mUpPartyProfiles) : true)) return BadRequest(ModelState);
                 if (!(party is Api.IDownParty downParty ? await validateModelGenericPartyLogic.ValidateModelAllowUpPartiesAsync(ModelState, nameof(downParty.AllowUpParties), mParty as DownParty) : true)) return BadRequest(ModelState);
                 if (!await validateModelGenericPartyLogic.ValidateModelClaimTransformsAsync(ModelState, mParty)) return BadRequest(ModelState);
@@ -177,7 +176,12 @@ protected async Task<ActionResult<AParty>> Put(AParty party, Func<AParty, ValueT
                     }
                 }
 
-                if (!(mParty is UpParty upParty ? await validateModelGenericPartyLogic.ValidateModelExtendedUiAsync(ModelState, upParty, true) : true)) return BadRequest(ModelState);
+                if(mParty is UpParty upParty)
+                {
+                    await validateModelGenericPartyLogic.HandleModelExtendedUiSecretAsync<AParty, AClaimTransform>(party, upParty);
+                }
+                await validateModelGenericPartyLogic.HandleClaimTransformationSecretAsync<AParty, AClaimTransform, MParty>(party, mParty);
+
                 if (!(mParty is UpParty ? validateModelGenericPartyLogic.ValidateModelUpPartyProfiles(ModelState, mUpPartyProfiles) : true)) return BadRequest(ModelState);
                 if (!(party is Api.IDownParty downParty ? await validateModelGenericPartyLogic.ValidateModelAllowUpPartiesAsync(ModelState, nameof(downParty.AllowUpParties), mParty as DownParty) : true)) return BadRequest(ModelState);
                 if (!await validateModelGenericPartyLogic.ValidateModelClaimTransformsAsync(ModelState, mParty)) return BadRequest(ModelState);

src/FoxIDs.Control/Controllers/Parties/TExternalLoginSecretUpPartyController.cs

@@ -44,7 +44,7 @@ public TExternalLoginSecretUpPartyController(TelemetryScopedLogger logger, ITena
                 {
                     return Ok(new Api.ExternalLoginSecretResponse
                     {
-                        Info = extLoginUpParty.Secret.Length > 20 ? extLoginUpParty.Secret.Substring(0, 3) : extLoginUpParty.Secret,
+                        Info = extLoginUpParty.Secret.GetShortSecret(false),
                     });
                 }
                 else

src/FoxIDs.Control/Extensions/ClaimExtensions.cs

@@ -1,5 +1,4 @@
-using Microsoft.Azure.Cosmos.Serialization.HybridRow.Schemas;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 using System.Security.Claims;
 using Api = FoxIDs.Models.Api;

src/FoxIDs.Control/Extensions/SecretExtensions.cs

@@ -0,0 +1,19 @@
+namespace FoxIDs
+{
+    public static class SecretExtensions
+    {
+        /// <summary>
+        /// Short secret returned in the API
+        /// </summary>
+        public static string GetShortSecret(this string secret, bool withDots)
+        {
+            if (secret != null && secret.Length > 20)
+            {
+                var shortSecret = secret.Substring(0, 3);
+                return withDots && shortSecret.Length == 3 ? $"{shortSecret}..." : shortSecret;
+            }
+
+            return secret;
+        }
+    }
+}

src/FoxIDs.Control/FoxIDs.Control.csproj

@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net9.0</TargetFramework>
-		<Version>2.0.9</Version>
+		<Version>2.0.10</Version>
 		<RootNamespace>FoxIDs</RootNamespace>
 		<Authors>Anders Revsgaard</Authors>
 		<Company>FoxIDs</Company>