-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Adding RPC interface to dynamic-sidecar
[part1]
#7251
base: master
Are you sure you want to change the base?
♻️ Adding RPC interface to dynamic-sidecar
[part1]
#7251
Conversation
…amic-sidecars-client-to-dynamic-scheduler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7251 +/- ##
==========================================
- Coverage 87.12% 86.90% -0.22%
==========================================
Files 1690 1525 -165
Lines 65579 61691 -3888
Branches 1121 891 -230
==========================================
- Hits 57133 53614 -3519
+ Misses 8128 7818 -310
+ Partials 318 259 -59
Continue to review full report in Codecov by Sentry.
|
…amic-sidecars-client-to-dynamic-scheduler
…amic-sidecars-client-to-dynamic-scheduler
…amic-sidecars-client-to-dynamic-scheduler
|
What do these changes do?
The RPC interface for the
dynamic-sidecar
goes into the direction of restorability and migrating the core services tok8s
. This allows us to decouple the networking, since the interface will be RabbitMQ.NOTE: since the REST interface will be deprecated once the old scheduler used by
director-v2
is removed, I am rewriting the tests for the RPC interface decoupled form the REST interface, to allow for easier removal of codeRelated issue/s
How to test
Dev-ops checklist