Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Adding RPC interface to dynamic-sidecar [part1] #7251

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 20, 2025

What do these changes do?

The RPC interface for the dynamic-sidecar goes into the direction of restorability and migrating the core services to k8s. This allows us to decouple the networking, since the interface will be RabbitMQ.

NOTE: since the REST interface will be deprecated once the old scheduler used by director-v2 is removed, I am rewriting the tests for the RPC interface decoupled form the REST interface, to allow for easier removal of code

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Feb 20, 2025
@GitHK GitHK added the t:maintenance Some planned maintenance work label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 67.52137% with 38 lines in your changes missing coverage. Please review.

Project coverage is 86.90%. Comparing base (ed01dce) to head (dcdb645).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7251      +/-   ##
==========================================
- Coverage   87.12%   86.90%   -0.22%     
==========================================
  Files        1690     1525     -165     
  Lines       65579    61691    -3888     
  Branches     1121      891     -230     
==========================================
- Hits        57133    53614    -3519     
+ Misses       8128     7818     -310     
+ Partials      318      259      -59     
Flag Coverage Δ
integrationtests 65.39% <71.79%> (+0.03%) ⬆️
unittests 85.86% <67.52%> (-0.28%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.53% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.26% <0.00%> (-0.50%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.73% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.06% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.91% <100.00%> (+0.17%) ⬆️
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.22% <ø> (+0.10%) ⬆️
storage 83.99% <ø> (-0.29%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.19% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed01dce...dcdb645. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant