-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fixes invalid invitation links #7057
🐛Fixes invalid invitation links #7057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
7ed892e
to
a6c800e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second issue due to that change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7057 +/- ##
==========================================
- Coverage 84.26% 82.06% -2.21%
==========================================
Files 1633 700 -933
Lines 63691 33668 -30023
Branches 2050 262 -1788
==========================================
- Hits 53670 27629 -26041
+ Misses 9684 5979 -3705
+ Partials 337 60 -277
Continue to review full report in Codecov by Sentry.
|
services/invitations/src/simcore_service_invitations/services/invitations.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happened also to me, such a pain to fix
Quality Gate passedIssues Measures |
Co-authored-by: Odei Maiz <[email protected]>
What do these changes do?
The issue arises in the latest Pydantic version, where
HttpUrl
automatically appends a trailing/
to URLs that consist only of an origin (i.e., without a path).Example:
However, when a path is included in the URL, Pydantic preserves the given format:
This behavior change affects cases where a strict distinction between
"http://origin"
and"http://origin/"
is necessary.Related issue/s
How to test
//
at the end.Dev-ops
None