fix: str::from builtin function with String
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISibboI
added
enhancement
|
Awesome, thanks! Seems like the CI is all screwed up, I'll look into that. |
ISibboI
force-pushed
the
main
branch
6 times, most recently
from
e4a8571 to
6608b16
Compare
- Added `from_str` function to `Value` that is called by the `str::from`
builtin function.
- `from_str` does not add quotation marks around an input string.
`str::from("foo")` returns `foo` instead of `"foo"` as before.
- Choice has been made to keep the use of `Value::to_string` formatting
for `Value::Tuple` variant.
`str::from((42, false, "foo"))` returns `(42, false, "foo")`
ISibboI
force-pushed
the
bugfix/strfrom
branch
from
81a61de to
eaa4ac0
Compare
|
Could you run |
Done, also removed use of "3.14" in my tests that were raising some warnings on github. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_strfunction toValuethat is called by thestr::frombuiltin function.from_strdoes not add quotation marks around an input string.str::from("foo")returnsfooinstead of"foo"as before.Value::to_stringformatting forValue::Tuplevariant. Therefore,str::from((42, false, "foo"))returns(42, false, "foo")