Skip to content

Remove pyright ignores for subscribers in RE calls #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove pyright ignores for subscribers in RE calls #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/callbacks/fitting/test_fit_logging_callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_after_fitting_callback_writes_to_file_successfully_no_y_uncertainty(
with patch("time.time", MagicMock(return_value=time)):
RE(
scan([invariant], mot, -1, 1, 3),
[lf, lfl], # pyright: ignore until https://github.com/bluesky/bluesky/issues/1938
[lf, lfl],
rb_number="0",
)

Expand Down Expand Up @@ -72,7 +72,7 @@ def test_fitting_callback_handles_no_rb_number_save(
with patch("time.time", MagicMock(return_value=time)):
RE(
scan([invariant], mot, -1, 1, 3),
[lf, lfl], # pyright: ignore until https://github.com/bluesky/bluesky/issues/1938
[lf, lfl],
)

assert m.call_args_list[0].args == (
Expand Down Expand Up @@ -104,7 +104,7 @@ def test_after_fitting_callback_writes_to_file_successfully_with_y_uncertainty(
with patch("time.time", MagicMock(return_value=time)):
RE(
scan([invariant, uncertainty], mot, -1, 1, 3),
[lf, lfl], # pyright: ignore until https://github.com/bluesky/bluesky/issues/1938
[lf, lfl],
rb_number="0",
)

Expand Down Expand Up @@ -144,7 +144,7 @@ def test_file_not_written_if_no_fitting_result(RE: run_engine.RunEngine):
):
RE(
scan([invariant], mot, -1, 1, 3),
[lf, lfl], # pyright: ignore until https://github.com/bluesky/bluesky/issues/1938
[lf, lfl],
rb_number="0",
)

Expand Down
Loading