Skip to content

DD-3465: Radio button hit area is too wide #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dd
Choose a base branch
from
Open

DD-3465: Radio button hit area is too wide #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb2d9d
DD-3465: Radio button hit area is too wide
Apr 16, 2018
b485be3
Override radio class style
Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions client/common/directives/ModelField/ModelField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,12 @@ angular.module('dashboard.directives.ModelField', [
ngOptions = 'text in display.options';
}
template = '<label class="col-sm-2 control-label">{{ display.label || key }}:</label>\
<div class="col-sm-10">\
<label ng-repeat="'+ngOptions+'" class="radio"><input type="radio" ng-model="data[key]" ng-value="value || text" ng-disabled="display.readonly" name="{{key}}"> {{text}}</label>\
<div class="col-sm-10">\
<div class="radio" ng-repeat="'+ngOptions+'"> \
<label><input type="radio" ng-model="data[key]" ng-value="value || text" ng-disabled="display.readonly" name="{{key}}"> {{text}}</label>\
<div class="model-field-description" ng-if="display.description !== false">{{ display.description }}</div>\
</div>';
</div>\
</div>';
break;
case 'slider':
template = '<label class="col-sm-2 control-label">{{ display.label || key }}:</label>\
Expand Down
3 changes: 3 additions & 0 deletions client/css/main.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ a:hover
.no-script-warning
padding: 10px
text-align: center
.radio
margin-top: 0px
margin-bottom: 0px