Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax networkx pin requirement #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nsoranzo
Copy link
Contributor

@nsoranzo nsoranzo commented Jun 29, 2024

Libraries should keep pins as lax as possible, see e.g.: https://stackoverflow.com/questions/28509481/should-i-pin-my-python-dependencies-versions

Main reason to open this now is that the currently pinned version (2.5) is not compatible with NumPy 2.0, while the latest releases work fine.

Also:

  • Add CI testing workflow
  • Ignore .venv/ directory
  • Update package version

nsoranzo added a commit to galaxybot/galaxy that referenced this pull request Jun 30, 2024
nsoranzo added a commit to galaxybot/galaxy that referenced this pull request Jun 30, 2024
nsoranzo added a commit to galaxybot/galaxy that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant