list_devices: adds support for several com ports #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the firmware change in the official PPK2 application 4.2.0, the device now enumerates two serial ports: one for data and commands, the other for a debug shell which is not used in this library. This forces connection with the port on endpoint 1.
wlgrd
force-pushed
the
support_multiple_endpoints
branch
from
5525bf1
to
2891553
Compare
wlgrd
changed the title
jupe
reviewed
Aug 29, 2024
| @@ -219,13 +219,13 @@ def list_devices(): | |||
| devices = [ | |||
| (port.device, port.serial_number[:8]) | |||
| for port in ports | |||
| if port.description.startswith("nRF Connect USB CDC ACM") | |||
| if port.description.startswith("nRF Connect USB CDC ACM") and port.location.endswith("1") | |||
There was a problem hiding this comment.
seems that location is same for both ports in macOS. But seems that first occurrence works there.
There was a problem hiding this comment.
I unfortunately don't have a mac to test with, but "first occurrence"; can you elaborate? The location should be derived from the USB hub tree, and both having the same location doesn't make sense to me as there has to be two logical endpoints on the device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the firmware change in the official PPK2 application 4.2.0, the device now enumerates two serial ports: one for data and commands, the other for a debug shell which is not used in this library. This forces connection with the port on endpoint 1.