added alignment for zero-based index for interaction_constraints #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainkad
commented
Nov 29, 2024
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| const INDEXPARAMS = [:categorical_feature] | |||
| const INDEXPARAMS = [:categorical_feature, :interaction_constraints] | |||
There was a problem hiding this comment.
Extended this to interaction_constraints param which requires similar zero-based indexing handling to categorical_feature.
There are some dataset params such as label_column, weight_column, or group_column can take a single index indicating the column, or the column name and these are added in https://github.com/IQVIA-ML/LightGBM.jl/pull/164/files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interaction_constraintsto theINDEXPARAMinteraction_constraintsto accept nowVector{Vector{Int}}instead of String (default for CLI but supported as a list of list in other languages)categorical_feature