Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in "requested access" email, add space after link to prevent it from breaking #11115

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Dec 19, 2024

What this PR does / why we need it:

Otherwise, the link doesn't work.

Which issue(s) this PR closes:

Special notes for your reviewer:

None.

Suggestions on how to test this:

Test manually or run mvn test -Dtest=AccessIT#testRequestAccess and then look at the emails generated.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Before (e.g. "id=9.")

Screenshot 2024-12-19 at 2 30 10 PM

After (e.g. "id=19 .")

Screenshot 2024-12-19 at 2 34 42 PM

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin pdurbin added Type: Bug a defect Feature: Notifications Size: 0.5 A percentage of a sprint. 0.35 hours FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) labels Dec 19, 2024
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Notifications FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Grant/deny access request link includes faulty "." in email
2 participants