Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant/deny access request link includes faulty "." in email #10384

Open
DieuwertjeBloemen opened this issue Mar 18, 2024 · 3 comments · May be fixed by #11115
Open

Grant/deny access request link includes faulty "." in email #10384

DieuwertjeBloemen opened this issue Mar 18, 2024 · 3 comments · May be fixed by #11115
Labels
Feature: Notifications Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug - Blocker Bug is blocking user work, no workaround available Type: Bug a defect

Comments

@DieuwertjeBloemen
Copy link
Contributor

DieuwertjeBloemen commented Mar 18, 2024

What steps does it take to reproduce the issue?
A user sending an access request.

  • When does this issue occur?
    In the email that the dataset users that have grant permission roles get once an access request has been sent.

  • Which page(s) does it occurs on?
    In the email (https://github.com/IQSS/dataverse/blob/develop/src/main/java/propertyFiles/Bundle.properties in "notification.email.requestFileAccess=File access requested for dataset: {0} by {1} ({2}). Manage permissions at {3}.", I believe)

  • What happens?
    The link to grant/deny the permissions is followed by a full stop, which by some email programs, like outlook, is seen as part of the link. This results in a non-functioning link, unless you delete the full stop from the end in the url bar. The landing page you get is also quite confusing as it looks to be the right page, just without any requests and without having to log in.

  • To whom does it occur (all users, curators, superusers)?
    All users who can grant/deny access to files.

  • What did you expect to happen?
    To land on the actual page to grant/deny access

Which version of Dataverse are you using?
5.14

Any related open or closed issues to this bug report?

Screenshots:
image

@DieuwertjeBloemen DieuwertjeBloemen added the Type: Bug a defect label Mar 18, 2024
@qqmyers
Copy link
Member

qqmyers commented Mar 18, 2024

FWIW: A work-around/potential fix is to add a space before the period in the Bundle.properties entry - I think this has been done in other places.

@pdurbin
Copy link
Member

pdurbin commented Mar 19, 2024

@DieuwertjeBloemen thanks for opening this issue. I know we discussed it in Mexico.

Yes, simply adding a space sounds like a good fix. Pull requests welcome!

@sbarbosadataverse sbarbosadataverse added the Size: 0.5 A percentage of a sprint. 0.35 hours label Jun 26, 2024
@sbarbosadataverse sbarbosadataverse moved this to SPRINT READY in IQSS Dataverse Project Jun 26, 2024
@cmbz cmbz added the Type: Bug - Blocker Bug is blocking user work, no workaround available label Jul 1, 2024
@DS-INRAE DS-INRAE moved this to ⚠️ Needed/Important in Recherche Data Gouv Nov 19, 2024
pdurbin added a commit that referenced this issue Dec 19, 2024
@pdurbin pdurbin moved this from SPRINT READY to In Progress 💻 in IQSS Dataverse Project Dec 19, 2024
@pdurbin pdurbin self-assigned this Dec 19, 2024
@pdurbin pdurbin moved this from In Progress 💻 to Done 🧹 in IQSS Dataverse Project Dec 19, 2024
@pdurbin pdurbin removed their assignment Dec 19, 2024
@pdurbin
Copy link
Member

pdurbin commented Dec 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Notifications Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug - Blocker Bug is blocking user work, no workaround available Type: Bug a defect
Projects
Status: Done 🧹
Status: ⚠️ Needed/Important
Development

Successfully merging a pull request may close this issue.

5 participants