-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify DTO sent to CreateCollection and UpdateCollection use cases #596
base: develop
Are you sure you want to change the base?
Conversation
tests/component/sections/shared/edit-create-collection-form/EditCreateCollectionForm.spec.tsx
Outdated
Show resolved
Hide resolved
tests/component/sections/shared/edit-create-collection-form/EditCreateCollectionForm.spec.tsx
Outdated
Show resolved
Hide resolved
Thanks @ChengShi-1, all changes requested made 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! approve
Hi @ofahimIQSS this is a known issue and is currently happening on beta. |
Hi German, unfortunately it isn't solved. The issue 588 relate to getDataset(), in dataset page, but this error above, happens collection page. We may need create a separate issue for this error. |
Another observation during testing this PR: I am unable to add Featured Items to the root collections [Edit - or any collection] page in my local environment - to reproduce:
Screen.Recording.2025-02-07.at.10.58.59.AM.mov |
Regression Testing also uncovered this: Screen.Recording.2025-02-07.at.11.41.39.AM.mov |
@ofahimIQSS about Collection description and Upload Files filePath bugs please feel free to open issues for that in the frontend repo, but they are not related to this change. |
I will go ahead and raise the bugs - thanks! [EDIT: Here they are: https://github.com//issues/599 & https://github.com//issues/600]
|
@ofahimIQSS great! I push a fix for the collection name. Please open an issue for the 403 Request Entity too large error on featured items creation, not sure what could be, working ok on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, small changes
...shared/form/EditCreateCollectionForm/collection-form/top-fields-section/TopFieldsSection.tsx
Outdated
Show resolved
Hide resolved
...shared/form/EditCreateCollectionForm/collection-form/top-fields-section/TopFieldsSection.tsx
Outdated
Show resolved
Hide resolved
my bad, please @ChengShi-1, check again |
Awesome, I'll take it for a spin.
Done: IQSS/dataverse#11238 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! length limit works on my end. Approve
Increased max length validation for collection name and affiliation fields to 255 characters. |
Can we get this PR reviewed please - merging is blocked :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
What this PR does / why we need it:
Modifies how we are sending the DTO while creating or updating a collection
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
In the SPA, edit the root collection, change any field, everything should be updated correctly.
Smoke test creating and updating sub collections could be nice also.