Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DTO sent to CreateCollection and UpdateCollection use cases #596

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Feb 5, 2025

What this PR does / why we need it:

Modifies how we are sending the DTO while creating or updating a collection

Which issue(s) this PR closes:

Special notes for your reviewer:

Please first Review and QA the JS-dataverse related PR IQSS/dataverse-client-javascript#250, once is merged I will update the js-dataverse package used in this PR and it will be ready for QA.

Suggestions on how to test this:

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm i && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature
In the SPA, edit the root collection, change any field, everything should be updated correctly.
Smoke test creating and updating sub collections could be nice also.

@g-saracca g-saracca added bug Something isn't working Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q1 Not related to any specific Q1 feature FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) labels Feb 5, 2025
@coveralls
Copy link

coveralls commented Feb 5, 2025

Coverage Status

coverage: 97.491% (+0.01%) from 97.481%
when pulling 09dc917 on modify-dto-create-update-collection
into 692283b on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1 Not related to any specific Q1 feature
Projects
Status: Ready for Review ⏩
Development

Successfully merging this pull request may close these issues.

Modify DTO sent to CreateCollection and UpdateCollection use cases - SPA frontend
2 participants