-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update keepRawFields to prevent markdown #588
Open
ChengShi-1
wants to merge
9
commits into
develop
Choose a base branch
from
587-edit-dataset-page-do-not-transform-metadata-values-to-markdown
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: update keepRawFields to prevent markdown #588
ChengShi-1
wants to merge
9
commits into
develop
from
587-edit-dataset-page-do-not-transform-metadata-values-to-markdown
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
added
bug
Something isn't working
SPA: Dataset page (View)
SPA: Edit Dataset Page
GREI Re-arch
GREI re-architecture-related
SPA.Q1
Not related to any specific Q1 feature
FY25 Sprint 15
FY25 Sprint 15 (2025-01-15 - 2025-01-29)
labels
Jan 24, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
g-saracca
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Good job 🚀 , just some minor suggestions.
Also take a look if this solves the underscores email issue and add it to the steps to test.
...ions/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFieldValueFormatted.tsx
Show resolved
Hide resolved
...ions/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFieldValueFormatted.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
FY25 Sprint 15
FY25 Sprint 15 (2025-01-15 - 2025-01-29)
FY25 Sprint 16
FY25 Sprint 16 (2025-01-29 - 2025-02-12)
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA: Dataset page (View)
SPA: Edit Dataset Page
SPA.Q1
Not related to any specific Q1 feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Related issue: IQSS/dataverse-client-javascript#244
We would move html to markdown transformation from js-dataverse repo to this frontend repo in dataset pages. We assume we will get raw dataset summary and metadata info from js-dataverse, and then we'll deal with the format transformation issue. Only if the field is in textbox type, we'll transform html tags into markdown.
keepRawField
parameter so as to getDataset with raw dataJSMetadataBlockInfoMapper.ts
, gettype
of fieldstype == 'TEXTBOX'
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Check the HTML Tags
<b> description </b>
<b>test</b>
, not as the rendered bold text or plain text.<b>test</b>
, not as the rendered bold text or plain text.Check the underscore escaping
refered to IQSS/dataverse-client-javascript#241
__description/title__
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: