Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underscores are escaped strangely with backslashes and accumulate #241

Closed
pdurbin opened this issue Jan 9, 2025 · 4 comments
Closed

underscores are escaped strangely with backslashes and accumulate #241

pdurbin opened this issue Jan 9, 2025 · 4 comments
Labels
bug Something isn't working FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1 Not related to any specific Q1 feature

Comments

@pdurbin
Copy link
Member

pdurbin commented Jan 9, 2025

What steps does it take to reproduce the issue?

Enter [email protected] under "Point of Contact".

  • When does this issue occur?

Always.

  • Which page(s) does it occur on?

https://beta.dataverse.org/spa/datasets?persistentId=doi:10.5072/FK2/SMVWNZ

  • What happens?

The email is rendered strangely as philip\\\[email protected]

  • To whom does it occur (all users, curators, superusers)?

All users.

  • What did you expect to happen?

The email should be rendered as [email protected]

Which version of Dataverse Frontend are you using?

66fd102

The version of the backend is IQSS/dataverse@6d6a509 if it helps.

Any related open or closed issues to this bug report?

Not that I could find.

Screenshots:

Screenshot 2025-01-09 at 12 35 25 PM

@ChengShi-1
Copy link
Contributor

Hi Phil,

Thanks for finding and creating this issue!

Here are some details about this issue:

When I first create datasets using my email, which includes an underscore in the middle. Initially, it didn’t display any unusual characters such as \ or others.
image.

However, when I clicked on "Edit Dataset" and opened the form, \ appeared before the underscore in the email. Every time I edited other contents and saved, the \ would reappear in front of the email and accumulate.
image.

@pdurbin pdurbin changed the title emails with underscores are escaped strangely with backslashes underscores are escaped strangely with backslashes and accumulate Jan 10, 2025
@pdurbin
Copy link
Member Author

pdurbin commented Jan 10, 2025

@ChengShi-1 ah, thanks for clarifying. I updated the title of this issue and added "accumulating". You're right, all fields are affected, not just email. Here's a test with the dataset title:

Screenshot 2025-01-10 at 10 53 43 AM

@g-saracca g-saracca added bug Something isn't working Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q1 Not related to any specific Q1 feature labels Jan 15, 2025
@cmbz cmbz added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 15, 2025
@ChengShi-1 ChengShi-1 self-assigned this Jan 17, 2025
@ChengShi-1 ChengShi-1 transferred this issue from IQSS/dataverse-frontend Jan 21, 2025
@ChengShi-1 ChengShi-1 linked a pull request Jan 21, 2025 that will close this issue
@ChengShi-1 ChengShi-1 removed their assignment Jan 21, 2025
@ekraffmiller
Copy link
Contributor

Hi @ChengShi-1, I realized when testing this that it is actually part of a bigger issue, that we need to address on the Edit Dataset Page. Rather than changing how the transform to Markdown works, we need to update the Edit Dataset Page to display the original html value. I created a frontend issue for it here. Sorry to not think of this sooner! I put the other issue in this Sprint, I think it's a relatively small change.

@ekraffmiller
Copy link
Contributor

Closing this since it is addressed in a dataverse-frontend issue: IQSS/dataverse-frontend#587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1 Not related to any specific Q1 feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants