Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display: initial; for all list item children in posts #149

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Jul 1, 2020

Changes

This pull request makes the following changes:

  • Adds display: initial; for any element that's a child of li inside of post content to fix issues where the items were broken onto a new line from the circle icon if the li content is wrapped inside of an element such as
<li dir="ltr">
   <p> XXXXXXX </p>
</li>

Before:
Screen Shot 2020-07-01 at 4 03 56 PM

After:
Screen Shot 2020-07-01 at 4 03 46 PM

Why

For #141, has no effect on #142 unfortunately

Testing/Questions

Features that this PR affects:

  • Items wrapped inside of an li element

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Does it look ok?

Steps to test this PR:

  1. View this post https://sfpp.test/uncategorized/san-francisco-shelter-in-place-order-could-be-extended-next-week/ (post id 4115) and make sure the list looks ok
  2. View a post with a normal list and make sure it looks ok

@joshdarby joshdarby added this to the Article Page milestone Jul 1, 2020
@joshdarby joshdarby requested a review from benlk July 1, 2020 20:06
@joshdarby joshdarby self-assigned this Jul 1, 2020
@joshdarby joshdarby merged commit 058b62b into master Jul 1, 2020
@joshdarby joshdarby removed their assignment Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants