Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list item circles appear before gallery items in the core Gallery block #142

Open
benlk opened this issue Jun 30, 2020 · 4 comments
Open

Comments

@benlk
Copy link
Collaborator

benlk commented Jun 30, 2020

Note the orange circles, which appear in master and in #140:

Screen Shot 2020-06-30 at 15 55 53

@joshdarby
Copy link

I'm not sure if there's a good and easy solution for this one, @MirandaEcho.

The easiest solution would be to just remove the orange circle for lists if it's a block gallery.

The reason it's complicated is because the <figure> element inside of the list item is display: flex; which messes with the spacing. Overriding that would mess with the placement of the image and the caption inside of the gallery which would probably lead us down a bigger rabbit hole than we want to go down.

@benlk
Copy link
Collaborator Author

benlk commented Jul 1, 2020

ul {
list-style: none;
li::before {
content: '\26AC';
color: @orange;
width: 1em;
text-align: center;
display: inline-block;
margin-left: -1em;
}

@MirandaEcho
Copy link
Collaborator

@joshdarby what's the status of this one? It wasn't on my list for prelaunch items, but it looks like maybe it was completed in which case I'll close out the issue.

@joshdarby
Copy link

@MirandaEcho This one was not completed yet. The other issue pertaining to the paragraphs and weird markup inside of lists was fixed. #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants