Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

119 remove file unattach #121

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

119 remove file unattach #121

wants to merge 2 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Nov 21, 2019 •
edited
Loading

Changes

This pull request makes the following changes:

  • Removes the "File Un-Attach" plugin.

Why

For #118; hopefully this will resolve the borked Media Gallery

Testing/Questions

Features that this PR affects:

  • learn.inn.org's media functionality

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • does this fix the problem that was reported?

Steps to test this PR:

  1. See Remove "File Un-Attach" plugin from cjet theme #118
  2. Does the Media Library work, when chosen from the WP sidebar? Can images be uploaded successfully?
  3. Does the media inserter in the post and page editors work? Does an image uploaded to there work?

@benlk benlk self-assigned this Nov 21, 2019
@benlk benlk changed the base branch from master to staging November 21, 2019 06:25
@benlk
Copy link
Collaborator Author

benlk commented Nov 21, 2019 •
edited
Loading

This is now deployed to http://learn-inn-org.inndev.staging.wpengine.com/ for review.

@benlk benlk removed their assignment Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MirandaEcho MirandaEcho Awaiting requested review from MirandaEcho

@joshdarby joshdarby Awaiting requested review from joshdarby

Assignees
No one assigned
Labels
site: learn.inn.org Status: Review Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benlk