Remove "File Un-Attach" plugin from cjet theme

[benlk]

https://wordpress.org/plugins/file-un-attach/
https://github.com/INN/umbrella-inndev/tree/master/wp-content/themes/cjet/lib/file-un-attach

This is what's causing the image problems on learn.inn.org

[benlk]

• update plugins on localhost to match staging — @MirandaEcho is this affecting just learn.inn.org or also the Learn staging site?
• investigate whether https://inn.org/wp-content/uploads/2019/07/noun_guide_2362366-336x336.png exists under a different subdomain
  
  

[MirandaEcho]

Both staging and prod for Learn.

…

On Fri, Nov 15, 2019, 8:51 PM Ben Keith ***@***.***> wrote: - update plugins on localhost to match staging — @MirandaEcho <https://github.com/MirandaEcho> is this affecting just learn.inn.org or also the Learn staging site? - investigate whether https://inn.org/wp-content/uploads/2019/07/noun_guide_2362366-336x336.png exists under a different subdomain [image: Screen Shot 2019-11-15 at 21 45 24] <https://user-images.githubusercontent.com/1754187/68986810-4d15ab80-07f1-11ea-8469-01008d006d7b.png> [image: Screen Shot 2019-11-15 at 21 46 10] <https://user-images.githubusercontent.com/1754187/68986814-5ef74e80-07f1-11ea-8ac2-860a8def2372.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118?email_source=notifications&email_token=ALQHBQJQDCI3HAG7K7IUOTTQT5N35A5CNFSM4JLX4PR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHHVLI#issuecomment-554597037>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQHBQJ26V3FIV5BSDMSSYDQT5N35ANCNFSM4JLX4PRQ> .

[benlk]

Further adventures of find-the-file, thanks to a find . on inndev's staging:

localhost: https://inndev.test/wp-content/uploads/sites/3/2019/08/noun_management_1871553-336x336-336x336.png
  staging: https://inndev.test/wp-content/uploads/2019/08/noun_management_1871553-336x336-336x336.png

so my local dev site doesn't have a db that matches the staging site's DB.

[benlk]

After resetting localhost from inndev staging:

localhost: https://inndevlearn.wpengine.com/wp-content/uploads/sites/3/2019/08/noun_management_1871553-336x336-336x336.png

so, uh, it looks like http://learn-inn-org.inndev.staging.wpengine.com/ is using a DB from inndevlearn.wpengine.com

[benlk]

After resetting localhost from inndev live, here's that same thumbnail:

    localhost: https://inndev.test/wp-content/uploads/sites/3/2019/06/noun_management_1871553-336x336.png
learn.inn.org: https://inn.org/wp-content/uploads/2019/08/noun_management_1871553-336x336-336x336.png
 staging find: wp-content/uploads/2019/08/noun_management_1871553-336x336-336x336.png

It shows up in the learn.inn.org media library, and find . on inndev staging reports that the file is found at wp-content/uploads/2019/08/noun_management_1871553-336x336-336x336.png which matches the expected path.

So we need a different image.

    localhost: https://inndev.test/wp-content/uploads/sites/3/2019/07/noun_guide_2362366-336x336.png
learn.inn.org: https://inn.org/wp-content/uploads/2019/07/noun_guide_2362366-336x336.png
 staging find: not found

[benlk]

That image is not on inn.org at:

https://inn.org/wp-content/uploads/2019/07/noun_guide_2362366-336x336.png
https://inn.org/wp-content/uploads/sites/3/2019/07/noun_guide_2362366-336x336.png

not on inndevlearn at:

https://learninndev.wpengine.com/wp-content/uploads/sites/3/2019/07/noun_guide_2362366-336x336.png
https://learninndev.wpengine.com/wp-content/uploads/2019/07/noun_guide_2362366-336x336.png

[benlk]

Found a must-use plugin on inn.org that wasn't on my localhost: change-upload-paths.php

<?php
/*
  Plugin Name: Change Uploads Paths
  Plugin URI: http://investigativenewsnetwork.org
  Description: Use the main uploads folder for all blogs
  Author: Adam Schweigert
  Version: 0.1
 */

add_filter('upload_dir', 'ms_global_upload_dir');

function ms_global_upload_dir($uploads)
{
    $ms_dir = '/sites/' . get_current_blog_id();

    $uploads['path']    = str_replace($ms_dir, "", $uploads['path']);
    $uploads['url']     = str_replace($ms_dir, "", $uploads['url']);
    $uploads['basedir'] = str_replace($ms_dir, "", $uploads['basedir']);
    $uploads['baseurl'] = str_replace($ms_dir, "", $uploads['baseurl']);

    return $uploads;
}

This explains where /sites/3 was coming from in the localhost URLs above, but it doesn't explain why the images are not present on any of the sites at any path.

[benlk]

These image files do not exist on prod at any image size.

[benlk]

These image files do not exist on the learninndev site, used for staging Learn.

@MirandaEcho I don't think this is a problem with the "File Un-Attach" plugin. I think these images are legitimately not present on the servers that are trying to use them.

New questions:

• We will have to re-upload these images.
  • Do we still have copies of them?
  • Do they exist in any site backup?
  • Do we have a comprehensive list of missing original images, that can be reuploaded and then have Regenerate Thumbnails run against them to recreate all the other image sizes?
• How did they go missing?

[benlk]

the original issue was that new images couldn't be uploaded or added, and the media gallery wasn't visible to users.

[benlk]

I can't reproduce the issue where images can't be uploaded or added, or the media gallery not being visible to users. The media gallery remains visible to my super-admin user, and I can upload images.

With the plugin active, note the weird formatting of the "close" button:

With the plugin removed, note the changed appearance of the "close" button:

So the plugin is doing something here. The next steps would be to create a user whose permissions match the affected users' permissions, and try from there.

@MirandaEcho do we just want to go ahead and remove the plugin rather than verifying that removing the plugin solves the problem?

[benlk]

Removing the File Un-Attach plugin from the child theme gives us the functional Media Library: