add filters for mapping #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rclations
reviewed
Aug 19, 2017
| DoubleClick_For_WordPress::VERSION, | ||
| 'all' | ||
| ); | ||
| if ( ! empty( get_option( 'dfw_css' ) ) ) { |
There was a problem hiding this comment.
Does this have a corresponding settings assoc. with it?
There was a problem hiding this comment.
yes, in https://github.com/INN/doubleclick-for-wp/blob/plugin-boilerplate/includes/class-options.php#L199
Hold off on merging this for a bit though, I need to add a thing to fire dfw_load(), probably in jquery.dfw.js on document ready but I want to make sure the timing is correct and a callback exists because we have some stuff we need to run before that loads so I just need to do a little more testing.
There was a problem hiding this comment.
@aschweigert Were you planning to add anything else to this pull request, or is it okay to close this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.