-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7주차] 기본/도전 과제 제출 #6
Open
m1njae
wants to merge
3
commits into
main
Choose a base branch
from
seminar7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onpyeong
reviewed
Dec 1, 2022
Comment on lines
+10
to
+13
const images: Express.MulterS3.File[] = req.files as Express.MulterS3.File[]; | ||
const imageList = images.map((image: Express.MulterS3.File) => { | ||
return image.location; | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미지 여러 개를 올릴 때는 [] 하면 되는군요!!👍
onpyeong
reviewed
Dec 1, 2022
router.get('/search', contentController.searchContentByName); | ||
|
||
//* 콘텐츠 생성 POST api/content | ||
router.post("/", upload.array("file"), contentController.createContent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single 대신 array를 사용하면 되는군요 굿굿
도전과제까지 하느라 고생 많았어유!! 이미지 저장은 저도 궁금하네요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER PR
🐕 과제 구현 명세
content 검색, pagination 기능을 제공하는 API를 추가하였고, content 등록 API에는 이미지 다중 업로드로 구현을 해보았습니다.
🐥 이런 점이 새로웠어요 / 어려웠어요